Status

task
P2
normal
RESOLVED FIXED
2 months ago
Last month

People

(Reporter: miker, Assigned: miker)

Tracking

(Blocks 1 bug)

Trunk
Firefox 70
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox70 fixed)

Details

Attachments

(1 attachment)

No description provided.
Attachment #9072698 - Attachment description: Bug 1560006 - Upgrade React to v16.8.6 → Bug 1560006 - Upgrade React to v16.8.6 r=nchevobbe!
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b68dc81adbf9
Upgrade React to v16.8.6 r=nchevobbe

Backed out changeset b68dc81adbf9 (Bug 1560006) for debugger failure

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=b68dc81adbf9c40c9181760791dc8da4ad87b761

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=252531129&repo=autoland&lineNumber=1444

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c497c45f090c25395b1b07680034e7653fb94d7f

[task 2019-06-19T23:43:50.746Z]       4TEST-UNEXPECTED-FAIL jest |   ● Tree › calls shouldItemUpdate when provided
[task 2019-06-19T23:43:50.746Z] TEST-UNEXPECTED-FAIL jest |   ● Tree › calls onFocus when expected
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● Tree › focus treeRef when a node is clicked
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● Tree › doesn't focus treeRef when focused is null
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● test String with URL › does render a link in a plain object
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › Basic render with mount
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › Basic render with mount & searchType = functions
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › Ensure anonymous functions do not render in QuickOpenModal
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › Basic render with mount & searchType = variables
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › Basic render with mount & searchType = shortcuts
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › updateResults on enable
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › basic source search
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › basic gotoSource search
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › empty symbol search › basic symbol search
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › empty symbol search › does not do symbol search if no selected source
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › Simple goto search query = :abc & searchType = goto
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › showErrorEmoji › true when no count + query
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › showErrorEmoji › false when count + query
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › showErrorEmoji › false when no query
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › showErrorEmoji › false when goto numeric ':2222'
[task 2019-06-19T23:43:50.747Z] TEST-UNEXPECTED-FAIL jest |   ● QuickOpenModal › showErrorEmoji › true when goto not numeric ':22k22'
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › has the expected expandedPaths state when clicking nodes
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › has the expected state when expanding a node
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › does not expand if the user selected some text
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › expands if user selected some text and clicked the arrow
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › does not throw when expanding a block node
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › calls recordTelemetryEvent when expanding a node
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - state › expanding a getter returning a longString does not throw
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should render with 0 expressions passed from props
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should render with 8 expressions passed from props
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should display xhr-input-method on click
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should have focused and editing default to false
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should have state {..focused: true, editing: true} on focus
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › shifting focus should unrender XHR methods
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › shifting focus to XHR methods should not unrender
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should have all 8 methods available as options
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should return focus to input box after selecting a method
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should submit the URL and method when adding a breakpoint
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● XHR Breakpoints › should submit the URL and method when editing a breakpoint
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders as expected
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › directly renders a Rep when the stub is not expandable
[task 2019-06-19T23:43:50.748Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders objects as expected when provided a name
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders primitives as expected when provided a name
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders as expected when not provided a name
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders leaves with a shorter mode than the root
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders less-important nodes as expected
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - renders › renders block nodes as expected
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● Frames › Supports different number of frames › shows the full URL
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ProjectSearch › found search results
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ProjectSearch › calls inputOnChange
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ProjectSearch › onKeyDown Escape/Other
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ProjectSearch › onKeyDown Enter
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ProjectSearch › onEnterPress shortcut no match or setExpanded
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ProjectSearch › onEnterPress shortcut match
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● Frame › filename only
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● Frame › full URL
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › calls the onFocus prop when provided one and given focus
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › doesn't call the onFocus when given focus but focusable is false
[task 2019-06-19T23:43:50.749Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › calls onDoubleClick prop when provided one and double clicked
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › calls the onCmdCtrlClick prop when provided and cmd/ctrl-clicked
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › calls the onLabel prop when provided one and label clicked
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › does not call the onLabel prop when the user selected text
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● Popover › encountered a declaration exception
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › does not load properties if properties are already loaded
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › calls enumProperties when expandable leaf is clicked
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › renders uninitialized bindings
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › renders unmapped bindings
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - properties › renders unscoped bindings
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - entries › renders Object with entries as expected
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - entries › calls ObjectClient.enumEntries when expected
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - Proxy › renders Proxy as expected
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - Proxy › calls enumProperties on <target> and <handler> clicks
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● createObjectClient › is called with the expected object for regular node
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● createObjectClient › is called with the expected object for entries node
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● createObjectClient › is called with the expected object for bucket node
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● createObjectClient › is called with the expected object for sub-bucket node
[task 2019-06-19T23:43:50.750Z] TEST-UNEXPECTED-FAIL jest |   ● createObjectClient › doesn't fail when ObjectClient doesn't have expected methods
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - getters & setters › renders getters as expected
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - getters & setters › renders setters as expected
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - getters & setters › renders getters and setters as expected
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - getters & setters › onInvokeGetterButtonClick + getter
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - getters & setters › onInvokeGetterButtonClick + setter
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - getters & setters › onInvokeGetterButtonClick + getter & setter
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - dimTopLevelWindow › renders window as expected when dimTopLevelWindow is true
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - dimTopLevelWindow › renders collapsed top-level window when dimTopLevelWindow =false
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - dimTopLevelWindow › renders sub-level window
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● release actors › calls release actors when unmount
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - keyboard navigation › works as expected
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● shouldItemUpdate › for longStrings
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● shouldItemUpdate › for basic object
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● createLongStringClient › is called with the expected object for longString node
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● createLongStringClient › substring › is called for longStrings with unloaded full text
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● createLongStringClient › substring › is not called for longString node w/ loaded full text
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - functions › renders named function properties as expected
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - functions › renders anon function properties as expected
[task 2019-06-19T23:43:50.751Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - functions › renders non-TINY mode functions as expected
[task 2019-06-19T23:43:50.752Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - classnames › has the expected class
[task 2019-06-19T23:43:50.752Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - classnames › has the nowrap class when disableWrap prop is true
[task 2019-06-19T23:43:50.752Z] TEST-UNEXPECTED-FAIL jest |   ● ObjectInspector - classnames › has the inline class when inline prop is true
[task 2019-06-19T23:43:50.752Z] TEST START | Stylelint
Flags: needinfo?(mratcliffe)
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b20e3609092
Backed out changeset b68dc81adbf9 for debugger failure
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5656e43f9b43
Upgrade React to v16.8.6 r=nchevobbe

Backed out changeset 5656e43f9b43 (bug 1560006) for debugger test fails at SourcesTreeItem.spec.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8acfa2e5536b3999ed017e38db6b1c8c0e065a7e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=5656e43f9b43f912e7f71a683504bddcc24aa757&selectedJob=252864973

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=252864973&repo=autoland&lineNumber=2284

Log snippet:

[task 2019-06-21T21:36:42.888Z] Snapshot Summary
[task 2019-06-21T21:36:42.888Z] › 18 snapshots failed from 2 test suites. Inspect your code changes or run yarn run test-ci -u to update them.
[task 2019-06-21T21:36:42.888Z]
[task 2019-06-21T21:36:42.888Z] Test Suites: 2 failed, 203 passed, 205 total
[task 2019-06-21T21:36:42.888Z] Tests: 18 failed, 8 skipped, 1712 passed, 1738 total
[task 2019-06-21T21:36:42.888Z] Snapshots: 18 failed, 422 passed, 440 total
[task 2019-06-21T21:36:42.888Z] Time: 110.585s
[task 2019-06-21T21:36:42.888Z] Ran all test suites in 5 projects.
[task 2019-06-21T21:36:42.888Z] error Command failed with exit code 1.
[task 2019-06-21T21:36:42.888Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show icon for webpack item
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show icon for angular item
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show icon for moz-extension item
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show icon for folder with arrow
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show icon for folder with expanded arrow
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show focused item for folder with expanded arrow
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show source item with source icon
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show (mapped) for duplicate source items
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show source item with source icon with focus
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show domain item
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show domain item as debuggee
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should show domain item as debuggee with focus and arrow
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should not show domain item when the projectRoot exists
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SourceTreeItem › renderItem › should unescape escaped source URLs
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● SearchBar › should render
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● showErrorEmoji › true if query + no results
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● showErrorEmoji › false if no query + no results
[task 2019-06-21T21:36:42.889Z] TEST-UNEXPECTED-FAIL jest | ● showErrorEmoji › false if query + results
[task 2019-06-21T21:36:42.889Z] TEST START | Stylelint

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:miker, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mratcliffe)
Flags: needinfo?(mratcliffe)
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.