1560061 - ConnectRoot(this.shadowRoot) not working

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P2)

Description

[danielleleb12]

document.l10n.connectRoot(this.shadowRoot) throws the console error "TypeError: Argument 1 of DOMLocalization.connectRoot does not implement interface Element."

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

To handle that we need to accept a type that can be a shadowRoot or an Element, and use the same type for DOMLocalization::mRoots.

smaug - what type should I use?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

nsINode would be the common type.
But should .l10n live in Document or in DocumentOrShadowRoot interface?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Olli Pettay [:smaug] from comment #2)

nsINode would be the common type.
Or nsIContent

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1560061 - Make DOMLocalization support ShadowDOM as roots.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Added a sanity test. There's more to solve wrt. shadow dom that :jaws is handling in bug 1555947 and bug 1553176, but this will allow for the document's l10n context to be used to cover shadowRoot.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/287a417a3f89
Make DOMLocalization support ShadowDOM as roots. r=smaug

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0581a4a4bdf3
Fix linting issues in test_connectRoot_webcomponent.html r=gandalf CLOSED TREE

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/287a417a3f89
https://hg.mozilla.org/mozilla-central/rev/0581a4a4bdf3

Comment 9

[Florin Strugariu [:Bebe]]

== Change summary for alert #21628 (as of Thu, 27 Jun 2019 09:58:05 GMT) ==

Improvements:

36% build times linux32-shippable opt nightly taskcluster-m4.4xlarge 7,558.74 -> 4,871.14

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21628