1560174 - JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 27}

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Daniel Holbert [:dholbert]]

I noticed this message in the logging on bug 1559761 comment 0:

08:57:59 INFO - Console message: [JavaScript Warning: "Removed unsafe attribute. Element: svg. Attribute: xmlns." {file: "resource://devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js" line: 27}]

That is from this chunk of JS:
**
const breakpointButton = document.createElement("button");
breakpointButton.innerHTML = '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 11 13" width="11" height="13"><path d="M5.07.5H1.5c-.54 0-1 .46-1 1v10c0 .54.46 1 1 1h3.57c.58 0 1.15-.26 1.53-.7l3.7-5.3-3.7-5.3C6.22.76 5.65.5 5.07.5z"/></svg>';
**

Apparently the xmlns doesn't make it into the actual document here, and it presumably doesn't matter since this is SVG-in-HTML5 which doesn't require a xmlns attribute at all.

We should just simplify that innerHTML assignment to drop the xmlns attribute to avoid triggering this warning.

Comment 1

[Daniel Holbert [:dholbert]]

https://searchfox.org/mozilla-central/rev/8ed8474757695cdae047150a0eaf94a5f1c96dbe/devtools/client/debugger/src/components/Editor/ColumnBreakpoint.js#31-33

This line seems to have been added in bug 1541563.

Comment 2

[David Walsh :davidwalsh]

Attachment: Bug 1560174 - Prevent xmlns warning for breakpoint SVGs r=jlast

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf8e7cbb75d6
Prevent xmlns warning for breakpoint SVGs r=jlast

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bf8e7cbb75d6