Closed Bug 1560235 Opened 5 years ago Closed 5 years ago

Sponsored label for cards no longer bottom aligned

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 69
Iteration:
69.4 - Jun 24 - Jul 7
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- verified

People

(Reporter: Mardak, Assigned: thecount)

References

(Regression)

Details

(Keywords: github-merged, regression)

Attachments

(2 files)

Screen Shot 2019-06-19 at 7.00.25 PM.png
232.73 KB, image/png
Details
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5121
52 bytes, text/x-github-pull-request
Details | Review

Regressed by bug 1550160

No longer depends on: 1550160
Regressed by: 1550160
See Also: → 1531104
Assignee: nobody → sdowne

There is also some margin bottom alignment issues that cause the sponsored by to not align with the bottom of the text of the adjacent cards which I'm planning on fixing with this.

Iteration: --- → 69.4 - Jun 24 - Jul 7
Priority: -- → P1
Blocks: 1561811
Keywords: github-merged

https://hg.mozilla.org/mozilla-central/rev/885c1d54bcb9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Component: Activity Streams: Newtab → New Tab Page

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190628161248) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now the "Sponsored by...." string is aligned with the text from the middle story, at the bottom of the card.

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: