Closed
Bug 1560281
Opened 5 years ago
Closed 5 years ago
The main process target should be of type "browser" and be notified on Target.setDiscoverTarget calls.
Categories
(Remote Protocol :: CDP, defect)
Remote Protocol
CDP
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ochameau, Assigned: ochameau)
Details
Attachments
(2 files)
This two requirements are necessary in order to make the following puppeteer's test to work.
Currently, the main process target is having a firefox-only "type" attribute (="main-process"), but chrome has a similar target whose type is "browser". So we should use the same type value.
Then, MainProcessTarget is currently special compared to tab targets. When we call Target.setDiscoverTargets, Target.targetCreated events are sent for all already opened tabs, but not for the MainProcessTarget. This prevent puppeteer from discovering this target and makes this test fail.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Attachment #9073000 -
Attachment description: Bug 1560281 - Flag main process target as "browser" one. → Bug 1560281 - Set main process target's "type" attribute to "browser".
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b429424f47a Set main process target's "type" attribute to "browser". r=remote-protocol-reviewers,ato https://hg.mozilla.org/integration/autoland/rev/7edbe1c6c1a7 Emit Target.targetCreated for the main process target. r=remote-protocol-reviewers,ato
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0b429424f47a
https://hg.mozilla.org/mozilla-central/rev/7edbe1c6c1a7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: CDP: Target → CDP
You need to log in
before you can comment on or make changes to this bug.
Description
•