1560284 - Long study names (over 100 chars) and string values are not fully displayed on about:studies

Status: VERIFIED FIXED

(Firefox :: Normandy Client, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: active experiment.png

[Affected versions]:

• Firefox Release 67.0.3, Build ID 20190618025334
• Firefox Beta 68.0b11, Build ID 20190617172838
• Firefox Nightly 69.0a1, Build ID 20190613215335

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Access to NORMANDY Delivery Console https://delivery-console.stage.mozaws.net/ is needed.
• Set the app.normandy.dev_mode preference to true to run recipes immediately on startup.
• Set the app.normandy.logging.level preference to 0 to enable more logging.
• Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
• Set the preference value for app.normandy.api_url to https://stage.normandy.nonprod.cloudops.mozgcp.net/api/v1.
• Set the services.settings.server preference to https://settings.stage.mozaws.net/v1.
• Have a preference experiment with a slug and preference string value longer than 100 characters already created and live eg #741
• Have the browser console opened.

[Steps to reproduce]:

1. Start the browser with the profile from prerequisites.
2. Navigate to about:studies and observe the studies' title and the pref value that is being set.

[Expected results]:

• Both title and pref value are fully visible on the page.

[Actual results]:

• In the title's case, the • Active part is not displayed. And in the pref value's case the last few characters are not displayed.

[Notes]:

• The slug name issue is also reproducible with add-on studies.
• If the slug and pref value is ~100 chars, they will be fully displayed once the study is completed. However if the pref's value is more than 100 chars it will still not be fully displayed.
• Attached a screenshot of the issue.

Comment 1

[Megha [ :meghaaa ]]

I would like to work on it, can I take this up?

Comment 2

[Michael Cooper [:mythmon]]

Yes, feel free to work on this bug.

I suspect that the problem is probably somewhere in this file: toolkit/components/normandy/content/about-studies/about-studies.js or the associated CSS file.

Comment 3

[Priyank Singh]

I guess I've found the problem,
willing to take this issue.

Comment 4

[Priyank Singh]

Attachment: Bug 1560284 - Long study names (over 100 chars) and string values are not fully displayed on about:studies

Comment 5

[Priyank Singh]

Any reviewer here, to review the patch?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/575970278433
Long study names (over 100 chars) and string values are not fully displayed on about:studies r=mythmon

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/575970278433

Comment 8

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Firefox Beta 70.0b5 (BuildID 20190909162732) and Nightly 71.0a1 (BuildID 20190911215306) on Windows 10, macOS 10.14.3, and Arch Linux 4.14.3.