Closed Bug 1560294 Opened 3 months ago Closed 3 months ago

Relax the assertion against `frameId` argument in Page.navigate

Categories

(Remote Protocol :: Page, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

This assertion in Page.navigate:

  async navigate({url, referrer, transitionType, frameId} = {}) {
    if (frameId) {
      throw new UnsupportedError("frameId not supported");
    }

Makes many puppeteer tests to fail as latest puppeteer versions always pass a frameId attribute, even for the top level tab document.
But this assertion was mostly meant to warn about this being unimplemented when you were trying to target an iframe. If frameId refers to the top level tab document, that is fine. This method will work as expected.

So we can refine this check in order to let it pass and keep iframe support for a followup.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/113fbb51b177
Relax frameId check in Page.navigate. r=remote-protocol-reviewers,ato
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.