1560322 - Console doesn't allow dismissing completion text

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect, P3)

Description

[sbdegutis]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. Open console
2. Type Object.has
3. Press Escape, or ctrl-a, or ctrl-b, (but left arrow works)

Actual results:

Console should get rid of "OwnProperty" ghostly-suggestion

Expected results:

Console's completion-suggestion of "OwnProperty" continues to haunt the user

Comment 1

[sbdegutis]

Whoops I got the things backwards. Actual/expected should be switched. Mea culpa.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the report sbdegutis , I confirm this is an issue.

Comment 3

[sbdegutis]

I wouldn't mind volunteering to fix it if someone could point me to the right file. Also to the source code repo's URL.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Sure.
So you can read https://docs.firefox-dev.tools/getting-started/ to set up the work environment (make sure to use Artifact builds as they're much faster to work with).
This is the place where we should handle this case devtools/client/webconsole/components/JSTerm.js#413-419 .
You can see that we call clearCompletion, but only if the autocomplete popup is open. We should also clear it if this.getAutoCompletionText() is not falsy.

Let me know if you have any issue, either here or on our Slack.

Thanks!

Comment 5

[sbdegutis]

1. The link you posted to has a dead link for "set up a development profile"
2. Is there a specific channel that's useful to discuss this code fix on that Slack server?
3. Thanks :)

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the dead link notice, I have a patch to fix it (https://phabricator.services.mozilla.com/D35486)

Comment 7

[sbdegutis]

Clicking the link now seems to change my address bar URL to the right place (per your patch), but it doesn't actually change any content in the browser (assuming some sort of client-side routing system).

Unfortunately I don't think I'll have time to be able to cooperate with making this patch in the timeline I thought I would be able to (e.g. within a day or two). I might be able to work on it in the longer term (e.g. maybe within a week or two), especially if I can convince my son to work with me on it as a way of getting him to understand open source better.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Unfortunately I don't think I'll have time to be able to cooperate with making this patch in the timeline I thought I would be able to (e.g. within a day or two). I might be able to work on it in the longer term (e.g. maybe within a week or two), especially if I can convince my son to work with me on it as a way of getting him to understand open source better.

Sounds great!

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Tested again and Escape seems to work fine for me