Enable webrender for Pixel 2 on GeckoView nightly
Categories
(Core :: Graphics: WebRender, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jnicol, Assigned: jnicol)
References
Details
Attachments
(1 file)
We decided we can do this during the work week. The Reference Browser should be the only affected product currently.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Kats, we want to confirm that doing this won't affect test configurations - eg the non-qr tests will still not use webrender?
Updated•5 years ago
|
Comment 3•5 years ago
|
||
I think the patch as written will enable WR on Fennec when running on Pixel 2 which is undesirable. You can use IsFennec() to exclude that case. I think it will also enable WR on any tests in automation that run on the Pixel2 hardware which includes a bunch of stuff.
We'll need to add support for explicitly disabling WR on those test harnesses via MOZ_WEBRENDER=0 before we can land this, I think.
Comment 4•5 years ago
•
|
||
Oh, actually ignore the Fennec thing. We already check for that here: https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/gfx/thebes/gfxPlatform.cpp#2928
(Geckoview tests that run on Pixel2 will still be affected)
Assignee | ||
Comment 5•5 years ago
|
||
Won't this prevent it being enabled on Fennec?
Do we already do something on desktop so that non-qr tests don't enable webrender? Or is that not a problem because the test hardware isn't qualified?
Comment 6•5 years ago
|
||
(In reply to Jamie Nicol [:jnicol] from comment #5)
Won't this prevent it being enabled on Fennec?
Yup, I guess we mid-aired on comment 4/5.
Do we already do something on desktop so that non-qr tests don't enable webrender? Or is that not a problem because the test hardware isn't qualified?
The test hardware is not qualified, except for tests that are running on windows virtual-with-gpu
instances. And the only non-WR tests that are doing that are AWSY tests, where we explicitly disable webrender. I was trying to clean that up in bug 1558598 and gave up after running into problems, but we'll have to push through and get that landed.
Comment 7•5 years ago
|
||
Now that the dep bug has landed this should be ok to land, at least from a "it won't break existing tests" point of view. We should keep an eye on crash stats after this lands though.
Comment 8•5 years ago
|
||
Jamie - is there a way to only do this for the reference browser for now?
Comment 9•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jnicol, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 10•5 years ago
|
||
We're waiting until we have a bit more clarity about what product we want this enabled in.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Pushed by jnicol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aca75dcd4379 Enable webrender for Pixel 2 on GeckoView Nightly. r=aosmond
Comment 12•5 years ago
|
||
Backed out changeset aca75dcd4379 (Bug 1560335) for android bustages complaining about gfxPlatform.cpp
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=aca75dcd43796c85c84eee9c7d03251e7405d9bd&tochange=65d289505f47b1fc0281355f813fc605c955f970&selectedJob=265795994
Backout link: https://hg.mozilla.org/integration/autoland/rev/65d289505f47b1fc0281355f813fc605c955f970
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265795994&repo=autoland&lineNumber=26112
[task 2019-09-09T21:35:07.809Z] 21:35:07 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers'
[task 2019-09-09T21:35:07.810Z] 21:35:07 INFO - gfx/layers/Unified_cpp_gfx_layers9.o
[task 2019-09-09T21:35:07.811Z] 21:35:07 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers'
[task 2019-09-09T21:35:08.469Z] 21:35:08 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/filesystem'
[task 2019-09-09T21:35:08.475Z] 21:35:08 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=x86_64-linux-android -o Unified_cpp_dom_filesystem0.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/filesystem -I/builds/worker/workspace/build/src/obj-firefox/dom/filesystem -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/fetches/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API_=21 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Oz -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_dom_filesystem0.o.pp Unified_cpp_dom_filesystem0.cpp
[task 2019-09-09T21:35:08.475Z] 21:35:08 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/filesystem'
[task 2019-09-09T21:35:08.490Z] 21:35:08 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-09-09T21:35:08.490Z] 21:35:08 INFO - mkdir -p '.deps/'
[task 2019-09-09T21:35:08.490Z] 21:35:08 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-09-09T21:35:08.514Z] 21:35:08 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-09-09T21:35:08.514Z] 21:35:08 INFO - dom/grid/Unified_cpp_dom_grid0.o
[task 2019-09-09T21:35:08.514Z] 21:35:08 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-09-09T21:35:08.904Z] 21:35:08 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/thebes'
[task 2019-09-09T21:35:08.908Z] 21:35:08 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=x86_64-linux-android -o gfxPlatform.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_ENABLE_FREETYPE -DGRAPHITE2_STATIC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/thebes -I/builds/worker/workspace/build/src/obj-firefox/gfx/thebes -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/xml -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/docs -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/fetches/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API_=21 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Oz -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/modules/freetype2/include -MD -MP -MF .deps/gfxPlatform.o.pp -Wno-implicit-fallthrough /builds/worker/workspace/build/src/gfx/thebes/gfxPlatform.cpp
[task 2019-09-09T21:35:08.908Z] 21:35:08 ERROR - /builds/worker/workspace/build/src/gfx/thebes/gfxPlatform.cpp:2633:13: error: unused function 'UpdateWRQualificationForNvidia' [-Werror,-Wunused-function]
[task 2019-09-09T21:35:08.908Z] 21:35:08 INFO - static void UpdateWRQualificationForNvidia(FeatureState& aFeature,
[task 2019-09-09T21:35:08.908Z] 21:35:08 INFO - ^
[task 2019-09-09T21:35:08.908Z] 21:35:08 ERROR - /builds/worker/workspace/build/src/gfx/thebes/gfxPlatform.cpp:2665:13: error: unused function 'UpdateWRQualificationForAMD' [-Werror,-Wunused-function]
[task 2019-09-09T21:35:08.908Z] 21:35:08 INFO - static void UpdateWRQualificationForAMD(FeatureState& aFeature,
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - ^
[task 2019-09-09T21:35:08.909Z] 21:35:08 ERROR - /builds/worker/workspace/build/src/gfx/thebes/gfxPlatform.cpp:2702:13: error: unused function 'UpdateWRQualificationForIntel' [-Werror,-Wunused-function]
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - static void UpdateWRQualificationForIntel(FeatureState& aFeature,
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - ^
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - 3 errors generated.
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - /builds/worker/workspace/build/src/config/rules.mk:785: recipe for target 'gfxPlatform.o' failed
[task 2019-09-09T21:35:08.909Z] 21:35:08 ERROR - make[4]: *** [gfxPlatform.o] Error 1
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/thebes'
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'gfx/thebes/target-objects' failed
[task 2019-09-09T21:35:08.909Z] 21:35:08 ERROR - make[3]: *** [gfx/thebes/target-objects] Error 2
[task 2019-09-09T21:35:08.909Z] 21:35:08 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-09-09T21:35:08.910Z] 21:35:08 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2019-09-09T21:35:08.911Z] 21:35:08 INFO - dom/base/Unified_cpp_dom_base6.o
[task 2019-09-09T21:35:08.912Z] 21:35:08 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2019-09-09T21:35:09.168Z] 21:35:09 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
[task 2019-09-09T21:35:09.173Z] 21:35:09 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=x86_64-linux-android -o Unified_cpp_dom_grid0.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/grid -I/builds/worker/workspace/build/src/obj-firefox/dom/grid -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/fetches/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=21 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Oz -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_dom_grid0.o.pp Unified_cpp_dom_grid0.cpp
[task 2019-09-09T21:35:09.175Z] 21:35:09 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/grid'
Comment 13•5 years ago
|
||
Pushed by jnicol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e23c7840a37 Enable webrender for Pixel 2 on GeckoView Nightly. r=aosmond
Comment 14•5 years ago
|
||
bugherder |
Description
•