1560336 - Firefox account menu item is misaligned on the right side when signed in

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1383535 +++

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs

Comment 2

[:Gijs (back August 25; he/him)]

Can you explain the summary? What is "misaligned", in what way, on what OS?

Comment 3

[Dão Gottwald [:dao]]

All OSes, I think, at least I've seen this on Windows and Linux, and the code is shared across platforms. It basically looks like the screenshot in bug 1383535 comment 0.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #3)

It basically looks like the screenshot in bug 1383535 comment 0.

Actually it's slightly worse than that, as not only the hover background is affected; the arrow is too far to the left even without hover.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3735712d5323
Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3735712d5323

Comment 7

[Itiel]

Fixed on latest Nightly.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 9073025 [details]
Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Firefox account menu item looks off
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed:

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9073025 [details]
Bug 1560336 - Stop using the toolbaritem-combined-buttons class for the Firefox account menu item. r=Gijs

low-risk CSS only fix, beta68+

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/29b838345c24

Comment 11

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 69.0a1 (2019.06.20) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 68.0b13 on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.13.6.