Closed Bug 1560370 Opened 1 year ago Closed 4 months ago

Move from using a vendored copy of webrtc-sdp in tree to using it as an external dependency

Categories

(Core :: WebRTC: Signaling, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: ng, Assigned: ng)

Details

Attachments

(1 file)

Now that the webrtc-sdp project is hosted by the Mozilla github[1] we should pull it in as build dependency instead of using a vendored copy of the code in tree. webrtc-sdp needs to be included as dependency of the rsdparsa_capi[2] in its Cargo.toml.

When running mach vendor rust I encounter:

./mach vendor rust
    Updating crates.io index
    Updating git repository `https://github.com/mozilla/webrtc-sdp`
 0:23.71 The following files exceed the filesize limit of 102400:

third_party/rust/webrtc-sdp/src/attribute_type.rs

Please find a way to reduce the sizes of these files or talk to a build
peer about the particular large files you are adding.

The changes from `mach vendor rust` will NOT be added to version control.

The file in question is currently in the tree. There is not much we can do at the moment to cut ~50Kb from the file.

(In reply to Nico Grunbaum [:ng] from comment #1)

When running mach vendor rust I encounter:

./mach vendor rust
    Updating crates.io index
    Updating git repository `https://github.com/mozilla/webrtc-sdp`
 0:23.71 The following files exceed the filesize limit of 102400:

third_party/rust/webrtc-sdp/src/attribute_type.rs

Please find a way to reduce the sizes of these files or talk to a build
peer about the particular large files you are adding.

The changes from `mach vendor rust` will NOT be added to version control.

The file in question is currently in the tree. There is not much we can do at the moment to cut ~50Kb from the file.

Pass --build-peers-said-large-imports-were-ok in this case as it's not a regression (assuming the vendored version is removed simultaneously of course).

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/bebdb508e737
move webrtc-sdp out of tree; r=drno
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.