1560370 - Move from using a vendored copy of webrtc-sdp in tree to using it as an external dependency

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Now that the webrtc-sdp project is hosted by the Mozilla github[1] we should pull it in as build dependency instead of using a vendored copy of the code in tree. webrtc-sdp needs to be included as dependency of the rsdparsa_capi[2] in its Cargo.toml.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

When running mach vendor rust I encounter:

./mach vendor rust
    Updating crates.io index
    Updating git repository `https://github.com/mozilla/webrtc-sdp`
 0:23.71 The following files exceed the filesize limit of 102400:

third_party/rust/webrtc-sdp/src/attribute_type.rs

Please find a way to reduce the sizes of these files or talk to a build
peer about the particular large files you are adding.

The changes from `mach vendor rust` will NOT be added to version control.

The file in question is currently in the tree. There is not much we can do at the moment to cut ~50Kb from the file.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

(In reply to Nico Grunbaum [:ng] from comment #1)

When running mach vendor rust I encounter:

./mach vendor rust
    Updating crates.io index
    Updating git repository `https://github.com/mozilla/webrtc-sdp`
 0:23.71 The following files exceed the filesize limit of 102400:

third_party/rust/webrtc-sdp/src/attribute_type.rs

Please find a way to reduce the sizes of these files or talk to a build
peer about the particular large files you are adding.

The changes from `mach vendor rust` will NOT be added to version control.

The file in question is currently in the tree. There is not much we can do at the moment to cut ~50Kb from the file.

Pass --build-peers-said-large-imports-were-ok in this case as it's not a regression (assuming the vendored version is removed simultaneously of course).

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1560370 - move webrtc-sdp out of tree; r?drno

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bebdb508e737
move webrtc-sdp out of tree; r=drno

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bebdb508e737

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bebdb508e737