Closed Bug 1560375 Opened 5 years ago Closed 5 years ago

The cross compartment wrapper map contains a per-compartment string map which could be shared between all compartments in a zone

Categories

(Core :: JavaScript: GC, task, P3)

Product:
Core
Component:
JavaScript: GC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Bug 1560375 - Share string wrappers between all comparments in a zone r=jandem?
47 bytes, text/x-phabricator-request
Details | Review

Strings don't have compartments and are shared between all comparments in a zone. However the CCW map has a sub map containing wrapped (well, copied) strings for each compartment. This is unnecessary and may result in extra string copies. We could replace this with a per-zone map in WrapperMap::put().

Priority: -- → P3
Depends on: 1571021
Assignee: nobody → jcoppeard

This moves the string wrapper map to the zone where it's shared by all compartments in the zone.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b02fef6b745
Share string wrappers between all comparments in a zone r=jandem?

https://hg.mozilla.org/mozilla-central/rev/4b02fef6b745

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: