Closed Bug 1560447 Opened 5 months ago Closed 5 months ago

about:logins is slow to display all the login count is greater than 100

Categories

(Firefox :: about:logins, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Keywords: perf, Whiteboard: [passwords:management] [skyline] )

Attachments

(2 files)

Profiling shows that 69% of the time is spent in crypto-SDR.js' decrypt method. We should try implementing a batch decryption method analogous to encryptMany and see if this fixes enough of the performance hit.

Flags: qe-verify-
Assignee: nobody → jaws
Status: NEW → ASSIGNED

@keeler, the last test case is failing and I believe it is an encoding issue but I'm not comfortable enough with this code. Can you help me out here?

Profile showing performance improvement of patch: https://perfht.ml/2X3svhK

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c2f7d75146b
Add a decryptMany method to crypto-SDR.js for batch decrypting of stored logins. r=keeler
https://hg.mozilla.org/integration/autoland/rev/e0311539d0fb
Add a getAllLoginsAsync method to LoginManager and call it from about:logins. r=mossop
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Regressions: 1562311
Whiteboard: [passwords:management] [skyline]
No longer regressions: 1562311
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla69 → Firefox 69
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.