1560448 - Discovery Stream hero unit campaign id impression bug

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

I don't think this is critical because we're not using hero unit on any active layouts.

Essentially what happens is spocs in the hero unit card position do not properly record impressions for the purposes of frequency capping. (the actual impressions still happens it's just not properly tracked as a spoc)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5124

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/885c1d54bcb9

Comment 3

[Scott [:thecount] Downe]

To test:

1. Set browser.newtabpage.activity-stream.discoverystream.endpoints to https,http
2. Set browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/a20a85e401502d80de485ecfb4f87953/raw/ad088934ab727e5c86e24ced0feaf4ae2b1891d7/layout-hero-spocs"}
3. Open a new tab
4. Ensure you see a spoc in position 1. (The big card, should say "sponsored by..." under the biggest image)
5. Refresh the page roughly 7 times, the spoc should change.
6. If you keep refreshing it again, it'll change again, and eventually you'll see no spocs.

Previously, frequency capping wasn't working in the big card, only worked in smaller cards, because the campaign id it used as an id to record the caps was busted.

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190702093917) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5, using the steps from comment 3.