Closed Bug 1560462 Opened 3 months ago Closed 3 months ago

Implement DOMMatrix.fromMatrix

Categories

(Core :: DOM: Core & HTML, enhancement)

69 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Currently several WPT tests for DOMMatrix depends on that operation.

Blocks: 1558101
Assignee: nobody → saschanaz

Also fixes .multiply() to use DOMMatrixInit.

Blocks: 1397945
Depends on: 1560658
Keywords: checkin-needed

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d63622bdde81
Implement DOMMatrix.fromMatrix r=bzbarsky

Keywords: checkin-needed

Backed out changeset d63622bdde81 (bug 1560462) for wpt failures at css/geometry/DOMMatrixInit-validate-fixup.html

Backout: https://hg.mozilla.org/integration/autoland/rev/edcb607325025e9622d21865f200089eb36dcd8f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d63622bdde81af2c25218e00b0420e5fe1dd9e39

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254114585&repo=autoland&lineNumber=23558

task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - TEST-PASS | /css/geometry/DOMMatrixInit-validate-fixup.html | {c: -0, m21: -0} (2d)
[task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - TEST-UNEXPECTED-FAIL | /css/geometry/DOMMatrixInit-validate-fixup.html | {d: Infinity, m22: Infinity} (2d) - assert_approx_equals: m22 expected Infinity +/- 0 but got Infinity
[task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - checkMatrix@http://web-platform.test:8000/css/geometry/support/dommatrix-test-util.js:41:7
[task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:91:5
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1594:25
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:89:3
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:88:3
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO -
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO - TEST-UNEXPECTED-FAIL | /css/geometry/DOMMatrixInit-validate-fixup.html | {e: -Infinity, m41: -Infinity} (2d) - assert_approx_equals: m41 expected -Infinity +/- 0 but got -Infinity
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO - checkMatrix@http://web-platform.test:8000/css/geometry/support/dommatrix-test-util.js:41:7
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:91:5
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1594:25
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:89:3
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:88:3
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO -
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO - TEST-UNEXPECTED-FAIL | /css/geometry/DOMMatrixInit-validate-fixup.html | {f: NaN, m42: NaN} (2d) - assert_approx_equals: m42 expected NaN +/- 0 but got NaN
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO - checkMatrix@http://web-platform.test:8000/css/geometry/support/dommatrix-test-util.js:41:7
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:91:5
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1594:25
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:89:3
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:88:3
[task 2019-06-29T23:14:03.738Z] 23:14:03 INFO -

Flags: needinfo?(saschanaz)
Flags: needinfo?(saschanaz)
Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/237163b50c8c
Implement DOMMatrix.fromMatrix r=bzbarsky

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17725 for changes under testing/web-platform/tests
Upstream PR merged

Documentation updated:

Please advise if there are any remaining issues with the content affected here.

You need to log in before you can comment on or make changes to this bug.