1560462 - Implement DOMMatrix.fromMatrix

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Currently several WPT tests for DOMMatrix depends on that operation.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1560462: Implement DOMMatrix.fromMatrix

Also fixes .multiply() to use DOMMatrixInit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d63622bdde81
Implement DOMMatrix.fromMatrix r=bzbarsky

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset d63622bdde81 (bug 1560462) for wpt failures at css/geometry/DOMMatrixInit-validate-fixup.html

Backout: https://hg.mozilla.org/integration/autoland/rev/edcb607325025e9622d21865f200089eb36dcd8f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d63622bdde81af2c25218e00b0420e5fe1dd9e39

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254114585&repo=autoland&lineNumber=23558

task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - TEST-PASS | /css/geometry/DOMMatrixInit-validate-fixup.html | {c: -0, m21: -0} (2d)
[task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - TEST-UNEXPECTED-FAIL | /css/geometry/DOMMatrixInit-validate-fixup.html | {d: Infinity, m22: Infinity} (2d) - assert_approx_equals: m22 expected Infinity +/- 0 but got Infinity
[task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - checkMatrix@http://web-platform.test:8000/css/geometry/support/dommatrix-test-util.js:41:7
[task 2019-06-29T23:14:03.731Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:91:5
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1594:25
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:89:3
[task 2019-06-29T23:14:03.732Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:88:3
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO -
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO - TEST-UNEXPECTED-FAIL | /css/geometry/DOMMatrixInit-validate-fixup.html | {e: -Infinity, m41: -Infinity} (2d) - assert_approx_equals: m41 expected -Infinity +/- 0 but got -Infinity
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO - checkMatrix@http://web-platform.test:8000/css/geometry/support/dommatrix-test-util.js:41:7
[task 2019-06-29T23:14:03.733Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:91:5
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1594:25
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:89:3
[task 2019-06-29T23:14:03.734Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:88:3
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO -
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO - TEST-UNEXPECTED-FAIL | /css/geometry/DOMMatrixInit-validate-fixup.html | {f: NaN, m42: NaN} (2d) - assert_approx_equals: m42 expected NaN +/- 0 but got NaN
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO - checkMatrix@http://web-platform.test:8000/css/geometry/support/dommatrix-test-util.js:41:7
[task 2019-06-29T23:14:03.736Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:91:5
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1594:25
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:30
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:89:3
[task 2019-06-29T23:14:03.737Z] 23:14:03 INFO - @http://web-platform.test:8000/css/geometry/DOMMatrixInit-validate-fixup.html:88:3
[task 2019-06-29T23:14:03.738Z] 23:14:03 INFO -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/237163b50c8c
Implement DOMMatrix.fromMatrix r=bzbarsky

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/237163b50c8c

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17725 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 8

[Eric Shepherd [:sheppy]]

Documentation updated:

• Updated the DOMMatrix and DOMMatrixReadOnly pages accordingly.
• Submitted BCD PR 4823 to update the compatibility data for the affected methods.

Please advise if there are any remaining issues with the content affected here.