Closed Bug 1560475 Opened 5 years ago Closed 5 years ago

Do not load AccountManager.js into msgAccountCentral.js

Categories

(MailNews Core :: Account Manager, task)

Product:
MailNews Core
Component:
Account Manager
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 69.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

1560475.patch
4.79 KB, patch
darktrojan
: review+
Details | Diff | Splinter Review

The mailnews/base/content/msgAccountCentral.js file shouldn't need to load whole AccountManager.js as it does not need to poke the internal state of the Account manager.

Attached patch 1560475.patch — — Splinter Review

If it included AccountManager.js only for the 2 helper functions, those belong into accountUtils.js.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=aca8087c347aae0a19c53cd23d1e9c1689eacd80

Attachment #9073151 - Flags: review?(geoff)
Comment on attachment 9073151 [details] [diff] [review]
1560475.patch

I'm sure I reviewed this already. I must not have set the + flag.
Attachment #9073151 - Flags: review?(geoff) → review+

Thanks.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/42c2ac13e002
Do not load AccountManager.js into msgAccountCentral.js. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: