1560476 - On Windows 7 the splitters aren't styled correctly

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

While testing a other patch I saw on Windows 7 that the splitters on the main window aren't correctly styled.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1560476-fix-closing-brace.patch

On Windows 10 you see no difference because the missing curly brace is in the windows 7 part.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1560476-fix-closing-brace.patch

Oops, this is better. Regressed by bug 1529988.

Comment 3

[Jorg K (CEST = GMT+2)]

The last patch doesn't look right, it only adds a }.

Comment 4

[Richard Marti (:Paenglab)]

This one is correct. This is the missing brace. The older patch moved one rule into the wrong media query.

This brace was removed here: https://hg.mozilla.org/comm-central/rev/5bd16138e796#l2.25

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073155 [details] [diff] [review]
1560476-fix-closing-brace.patch

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fdd1ee5faf32
Fix a missing closing brace (from bug 1529988). Broke the splitter display on Windows 7. r=jorgk

Comment 8

[Jorg K (CEST = GMT+2)]

Sigh, that was fixed in TB 69 and never uplifted to TB 68 beta since with no target milestone is didn't get picked up in the queries :-(

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.2.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/0eacabd0074dc2479fdad14eeaa95eae11e1d481