Closed
Bug 1560509
Opened 5 years ago
Closed 5 years ago
Remove unneeded rule from panelUI.css
Categories
(Thunderbird :: Theme, task)
Thunderbird
Theme
Tracking
(thunderbird68 fixed, thunderbird69 fixed)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
1.10 KB,
patch
|
pmorris
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
panelUI.css has a rule that never applies because it checks for the browser window ID #main-window. In bug 1560338 this rule was removed. So it's good to remove it too.
Assignee | ||
Comment 1•5 years ago
|
||
Remove it.
Comment 2•5 years ago
|
||
Comment on attachment 9073178 [details] [diff] [review] 1560509-remove-rule-from-panelUI.css.patch Review of attachment 9073178 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks for catching this.
Attachment #9073178 -
Flags: review?(paul) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/342eb3a6e773
Remove unneeded rule from panelUI.css. r=pmorris DONTBUILD
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 69.0
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9073178 [details] [diff] [review] 1560509-remove-rule-from-panelUI.css.patch This rule is in beta too.
Attachment #9073178 -
Flags: approval-comm-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9073178 [details] [diff] [review] 1560509-remove-rule-from-panelUI.css.patch OK, but it doesn't do any harm.
Attachment #9073178 -
Flags: approval-comm-beta? → approval-comm-beta+
Comment 6•5 years ago
|
||
TB 68 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/d9c87a16811c01393bead8016bce08bd576fa7b6
status-thunderbird68:
--- → fixed
status-thunderbird69:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•