1560582 - Crash in [@ OOM | large | mozalloc_abort | mozalloc_handle_oom | moz_xrealloc | SkGlyphRunListPainter::drawForBitmapDevice]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[[:philipp]]

This bug is for crash report bp-8abb908d-fa99-4a23-b8c4-ff8b60190621.

Top 10 frames of crashing thread:

0 mozglue.dll mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:33
1 mozglue.dll mozalloc_handle_oom memory/mozalloc/mozalloc_oom.cpp:51
2 mozglue.dll moz_xrealloc memory/mozalloc/mozalloc.cpp:90
3 xul.dll SkGlyphRunListPainter::drawForBitmapDevice gfx/skia/skia/src/core/SkGlyphRunPainter.cpp:237
4 xul.dll void SkBitmapDevice::drawGlyphRunList gfx/skia/skia/src/core/SkBitmapDevice.cpp:541
5 xul.dll SkGlyphRunBuilder::drawTextBlob gfx/skia/skia/src/core/SkGlyphRun.cpp:232
6 xul.dll SkCanvas::onDrawTextBlob gfx/skia/skia/src/core/SkCanvas.cpp:2552
7 xul.dll SkCanvas::drawTextBlob gfx/skia/skia/src/core/SkCanvas.cpp:2573
8 xul.dll void mozilla::gfx::DrawTargetSkia::DrawGlyphs gfx/2d/DrawTargetSkia.cpp:1384
9 xul.dll void mozilla::gfx::DrawTargetSkia::FillGlyphs gfx/2d/DrawTargetSkia.cpp:1390

this is a low-to-mid-volume signature newly showing up in firefox 68 (not seeing it in 69.0a1 anymore) - 32bit installations are more commonly affected by this oom crash.
it seems linked to the skia update in bug 1539026.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1560582 - limit Skia glyph batch sizes. r?jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57ef2080d3f
limit Skia glyph batch sizes. r=jrmuizel

Comment 3

[Lee Salzman [:lsalzman]]

This patch should limit Skia's allocations to sane sizes for us so that we aren't OOMing.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e57ef2080d3f

Comment 5

[Lee Salzman [:lsalzman]]

Comment on attachment 9074418 [details]
Bug 1560582 - limit Skia glyph batch sizes. r?jrmuizel

Beta/Release Uplift Approval Request

• User impact if declined: Potential OOM crashes when rendering web pages with lots of text.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just makes text render in smaller batches to limit memory allocations.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9074418 [details]
Bug 1560582 - limit Skia glyph batch sizes. r?jrmuizel

Fixes an OOM crash regression caused by the Skia update shipping in 68. Approved for 68rc1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/48a056813b7d