Closed Bug 156060 Opened 23 years ago Closed 23 years ago

bubbles theme causes flicker in nsITheme tabs

Categories

(Core Graveyard :: Skinability, defect)

x86
Linux
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ian, Assigned: bryner)

Details

Attachments

(1 file, 1 obsolete file)

STEPS TO REPRODUCE 1. Install and use the Bubbles GTK theme. 2. Open and nsITheme-enabled Mozilla and switch to the Classic skin. 3. Open a new tab. 4. Click on the tab; hover over the tab, switch tab back and forth, etc. ACTUAL RESULTS The tab background inexplicably flickers between different pixmaps.
Status: NEW → ASSIGNED
Attached patch patch (obsolete) — Splinter Review
Here's a first cut at a patch. Basically, I'm ensuring that any tile that's applied will have its origin at the frame origin, which I think is what we want. I'm not sure if resetting the tile/stipple origin on these GC's all the time is a performance problem or not...
Attached patch patch #2Splinter Review
optimization: don't bother resetting the offset to 0,0. Nobody else is using these gc's.
Attachment #90471 - Attachment is obsolete: true
checked in (not part of the build yet)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
VERIFIED -- that works. Sorry I never got round to testing the patch, I suck.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: