1560669 - services should crash when started with insufficient config

Status: NEW

(Taskcluster :: Services, enhancement)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

We should prefer to crash early when config is not present or not correct.

I think we're inconsistent about this, and it leads to service deployments that look like they're working (process is running) but are actually completely nonfunctional.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

The one case I know of is that auth will start without GCP credentials. We should follow up to fix that. Wander, is anything blocking doing so?

Otherwise, I think the easiest way to test this will be to do some experimenting with kubectl and see what doesn't crash.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I was tempted to WONTFIX this, since stuff pretty much does crash without config -- but the error messages are especially inscrutable.

I think I'll add something to the config library to allow cleanly asserting that configuration values are present with decent error messages.

Comment 3

[Wander Lairson Costa]

(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #1)

The one case I know of is that auth will start without GCP credentials. We
should follow up to fix that. Wander, is anything blocking doing so?

Otherwise, I think the easiest way to test this will be to do some
experimenting with kubectl and see what doesn't crash.

Not that I know.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I found another one: tc-web-server will start up without JWT keys

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Brian, can you mix this in with the deployment-config work you're doing?

Comment 6

[Brian Stack [:bstack]]

Yep, I'll get it in today.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

I'll mix this into the planned deployment-configuration-updates work

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster/projects/8?add_cards_query=is%3Aopen