1560699 - Consider downloading ftp:// resources rather than rendering them.

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, enhancement, P1)

Description

[Darkspirit]

https://github.com/whatwg/fetch/pull/839#issuecomment-446985221

ckerschb commented on 13 Dec 2018
Firefox has been blocking FTP subresource loads within http(s) documents since Firefox 61 for a variety of reasons as a first step of deprecating FTP resource loads in the browser. It makes sense to me that we start treating FTP resources as binary data instead of rendering them as the next step.

Comment 1

[Junior [inactive]]

Please correct me if I put to wrong component.

Comment 2

[Honza Bambas (:mayhemer)]

Loose P1 - let's try to fix this in this release.

Comment 3

[Honza Bambas (:mayhemer)]

Michal, this is mostly about changing the content type we expose on the ftp channel. You know this code well, do you think you could fix this for this release?

Comment 4

[Darkspirit]

Together with this change you could revert https://hg.mozilla.org/mozilla-central/rev/33db56e4ee57 and https://hg.mozilla.org/mozilla-central/rev/70ab5d0f6da3.

Comment 7

[Darkspirit]

Attachment: Bug 1560699 - Download FTP resources instead of rendering them.

Comment 8

[Darkspirit]

Tested with emulated Fennec and Desktop Nightly on Debian Testing. Please trigger a try build, if possible.

Rendered: ftp://ftp.de.debian.org/
Downloaded:
ftp://ftp.de.debian.org/debian/README
ftp://ftp.de.debian.org/debian/README.mirrors.html
ftp://ftp.ripe.net/ripe/training/role-object.mov (This would be rendered if we didn't prevent MIME sniffing.)
ftp://ftp.ripe.net/ripe/training/RIPENCC-IPv6-Exercise.pdf

Comment 9

[Michal Novotny [:michal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0574bea02da51b1f1604271c469c2992648aae2d

Comment 10

[Michal Novotny [:michal]]

Looks good to me. Thanks for the patch!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29e52be56fee
Download FTP resources instead of rendering them. r=michal

Comment 12

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.dev/en-CA/docs/2019/all-ftp-resources-are-now-downloaded-instead-of-being-rendered/

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/29e52be56fee

Comment 14

[Darkspirit]

bug 1475261: Connection errors are empty text instead of error pages. Example: ftp://cyberghost.pro:80/pro.php

Therefore an empty file is now offered to download.