Closed
Bug 1560820
Opened 5 years ago
Closed 5 years ago
Remove `sGfxLogLevel`
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
sGfxLogLevel just duplicates the "gfx.logging.level" pref, and can be removed.
|
Assignee | |
Comment 1•5 years ago
|
||
sGfxLogLevel is a global variable whose value mirrors the value of the
"gfx.logging.level" pref in the prefs table, and is kept up to date by a
prefs callback.
But because "gfx.logging.level" is a VarCache pref, there is already another
such global variable which is accessible via StaticPrefs::GfxLoggingLevel().
So we can use the latter and remove the former, and this patch does that. The
patch also removes a sentence in a comment that refers to special treatment of
LOG_DEBUG and LOG_DEBUG_PRLOG, because that sentence appears to be referring to
something (another comment?) that is no longer present.
|
||
Updated•5 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Priority: -- → P3
|
|
Assignee | |
Comment 2•5 years ago
|
||
jrmuizel: 6 day review ping
|
|
Assignee | |
Comment 3•5 years ago
|
||
jrmuizel: 22 day review ping
|
||
Updated•5 years ago
|
Attachment #9073470 -
Attachment description: Bug 1560820 - Remove `sGfxLogLevel`. r=mattwoodrow → Bug 1560820 - Remove `sGfxLogLevel`. r=nical
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6528e8780ec Remove `sGfxLogLevel`. r=nical
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•