Closed
Bug 1560833
Opened 5 years ago
Closed 5 years ago
Remove setters for static VarCache prefs.
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
They are dangerous.
|
Assignee | |
Comment 1•5 years ago
|
||
Static VarCache prefs have setters. These are dangerous because they can
violate the primary invariant of VarCache prefs, which is that the global
variable always matches the pref value in the table.
Fortunately they are only used in tests, and we can use vanilla pref setters
instead, and get rid of the VarCache setters.
|
|
Assignee | |
Updated•5 years ago
|
Type: defect → enhancement
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11459fc963ac Remove setters for static VarCache prefs. r=froydnj
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
||
Updated•5 years ago
|
Assignee: nobody → n.nethercote
|
||
Comment 4•5 years ago
|
||
An unfortunate consequence of this change is that in the APZ gtests, names of modified prefs have to be provided as strings, so the compiler no longer catches typos and such.
You need to log in
before you can comment on or make changes to this bug.
Description
•