1560855 - Recorder is not aware of SourceSurfaceCanvasRecording

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Bob Owen (:bobowen) - PTO until 3rd April]

The canvas DrawEventRecorder is not aware of SourceSurfaceCanvasRecordings that are wrapping other SourceSurfaces.

This means when a SourceSurfaceCanvasRecording is not used to get data (i.e. when it is passed back into a DrawTarget) it is re-recorded, which involves pulling all the data back from the GPU process and pushing it back up again.

To fix this I'm going to add two new canvas RecordedEvents.
One to set up the SourceSurfaceCanvasRecording as an alias to the surface it wraps equivalent surface in the GPU process.
Another to remove that alias, when the SourceSurfaceCanvasRecording is destroyed in the content process.

Comment 1

[Bob Owen (:bobowen) - PTO until 3rd April]

Attachment: Bug 1560855: Make recorder aware of SourceSurfaceCanvasRecordings. r=jrmuizel!

This is done my adding two new canvas RecordedEvents, which add and remove the
SourceSurfaceCanvasRecording as an alias to the SourceSurfaces that they wrap.

Depends on D37088

Comment 2

[Bob Owen (:bobowen) - PTO until 3rd April]

https://treeherder.mozilla.org/#/jobs?repo=try&duplicate_jobs=visible&selectedJob=255022538&revision=08ff233b9260539ba415742331e99ab7fda16afd

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aded829fd7a
Make recorder aware of SourceSurfaceCanvasRecordings. r=jrmuizel

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0aded829fd7a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is there a user impact which justifies backport consideration or can this fix ride the trains?

Comment 6

[Bob Owen (:bobowen) - PTO until 3rd April]

Remote 2D canvas is disabled at the moment.