Closed Bug 1560869 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17377 - Add CEReactions and CustomElementCallbacks to toggleAttribute

Categories

(Core :: DOM: Core & HTML, defect, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17377 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17377
Details from upstream follow.

Rakina Zata Amni <rakina@chromium.org> wrote:

Add CEReactions and CustomElementCallbacks to toggleAttribute

Previously the IDL definition for toggleAttribute doesn't have
those modifiers, so they behave differently than setAttribute when
called on custom elements (it won't fire attributeChangedCallback, etc)
Bug: 976177

Change-Id: I7d8107db8d07a2e2ec856305c56a178339c5e05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663881
Commit-Queue: Rakina Zata Amni \<rakina@chromium.org>
Commit-Queue: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Auto-Submit: Rakina Zata Amni \<rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670060}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/34264607b5d1 [wpt PR 17377] - Add CEReactions and CustomElementCallbacks to toggleAttribute, a=testonly

https://hg.mozilla.org/mozilla-central/rev/34264607b5d1

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.