Closed Bug 1560915 Opened 2 months ago Closed Last month

Hardcode minimal eval()-whitelist for test files into eval()-assertion

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jallmann, Assigned: jallmann)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Some testing-related files using eval()-like functions are hard to be replaced/amended. They are probably going to stay whitelisted from the eval()-assertion. This solution is preferred over manually disabling the assertion in many tests and possibly shadowing the use of eval() in places other than these few, known files.
A minimal whitelist of files identified by their full path is going to be hardcoded into the assertion to replace the current pref-based whitelist.
Additionally, it should be ensured that even the whitelisted files are only allowed when running in automation.

See Also: → 1558986
Priority: -- → P2
Whiteboard: [domsecurity-active]
Keywords: checkin-needed

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/6e76b0cb3e10
Hardcode minimal eval()-whitelist for test files into eval()-assertion, r=ckerschb

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.