1560915 - Hardcode minimal eval()-whitelist for test files into eval()-assertion

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Jonas Allmann [:jallmann]]

Some testing-related files using eval()-like functions are hard to be replaced/amended. They are probably going to stay whitelisted from the eval()-assertion. This solution is preferred over manually disabling the assertion in many tests and possibly shadowing the use of eval() in places other than these few, known files.
A minimal whitelist of files identified by their full path is going to be hardcoded into the assertion to replace the current pref-based whitelist.
Additionally, it should be ensured that even the whitelisted files are only allowed when running in automation.

Comment 1

[Jonas Allmann [:jallmann]]

Attachment: Bug 1560915 - Hardcode minimal eval()-whitelist for test files into eval()-assertion, r=ckerschb

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e76b0cb3e10
Hardcode minimal eval()-whitelist for test files into eval()-assertion, r=ckerschb

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6e76b0cb3e10