Closed Bug 1560916 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17395 - Worker: Deflake worker-interception.https.html

Categories

(Core :: DOM: Service Workers, defect, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17395 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17395
Details from upstream follow.

Hiroki Nakagawa <nhiroki@chromium.org> wrote:

Worker: Deflake worker-interception.https.html

This is a follow-up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/1657855/10#message-de50523b6c1fc520cf1a7c2edf3033d4e2139103

worker-interception.https.html is flaky on Firefox. It looks like service worker
unregistration is unexpectedly canceled. Each test case doesn't explicitly
terminate (shared) workers, so they may prolong the lifetime of the registration
being unregistered, and the next test case may unexpectedly reuse it. This
results in failures in setup_service_worker().

To fix it, this CL separates service worker scope per test. Note that explicit
worker termination should not work in this case because shared workers are
out-of-process workers and it's not possible to terminate them
deterministically.

Bug: n/a
Change-Id: I16c32d6477c8b1a4d1a246b33a8e21747b4fec66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663459
Reviewed-by: Matt Falkenhagen \<falken@chromium.org>
Commit-Queue: Hiroki Nakagawa \<nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670831}

PR 17395 applied with additional changes from upstream: 3671eb9b321c60898a79c76d20a97807925ebe1e
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/1480e3eb9d60 [wpt PR 17395] - Worker: Deflake worker-interception.https.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1480e3eb9d60

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.