Closed Bug 1560932 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17364 - [Native File System] Create FileSystemFileWriterImpl to mirror the renderer side

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17364 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17364
Details from upstream follow.

Olivier Yiptong <oyiptong@chromium.org> wrote:

[Native File System] Create FileSystemFileWriterImpl to mirror the renderer side

This is the initial cl of the refactor of NativeFileSystemFileHandleImpl to
mirror the split on the renderer side with the handle and the writer as
two separate entities.

It is the initial implementation for FileSystemFileWriterImpl. It includes
only one no-op method for now: close().

This sets the stage for atomic writes as close() will be the explicit
termination of a write, which allows us to do the atomic operation.

Bug: 968550
Change-Id: I0af81efa46789f18c4a8b0bca3ab89c5703b798c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662709
Commit-Queue: Olivier Yiptong \<oyiptong@chromium.org>
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink \<mek@chromium.org>
Auto-Submit: Olivier Yiptong \<oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671539}

Failed to get results from try push
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7e1c883552 [wpt PR 17364] - [Native File System] Create FileSystemFileWriterImpl to mirror the renderer side, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9a7e1c883552

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.