Closed Bug 1560942 Opened 4 months ago Closed 3 months ago

Perf regression in Debugger DAMP tests after enabling event listener breakpoints

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 fixed, firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: jdescottes, Assigned: jlast)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [debugger-mvp])

Attachments

(2 files)

From the following perfherder alert:
https://treeherder.mozilla.org/perf.html#/alerts?id=21545

== Change summary for alert #21545 (as of Sun, 23 Jun 2019 07:43:54 GMT) ==

Regressions:

 42%  damp custom.jsdebugger.stepOut.DAMP windows7-32-shippable opt e10s stylo            402.26 -> 569.20
 18%  damp custom.jsdebugger.project-search.DAMP windows7-32-shippable opt e10s stylo     1,976.33 -> 2,336.04
 16%  damp custom.jsdebugger.stepOver.DAMP windows7-32-shippable opt e10s stylo           274.92 -> 319.88
 13%  damp custom.jsdebugger.pause.DAMP windows7-32-shippable opt e10s stylo              324.12 -> 365.26
 11%  damp custom.jsdebugger.stepIn.DAMP windows7-32-shippable opt e10s stylo             405.28 -> 448.60
  7%  damp custom.jsdebugger.preview.DAMP windows7-32-shippable opt e10s stylo            649.36 -> 695.72
  7%  damp simple.jsdebugger.open.DAMP windows7-32-shippable opt e10s stylo               650.40 -> 696.76
  7%  damp cold.jsdebugger.open.DAMP windows7-32-shippable opt e10s stylo                 675.77 -> 722.99
  5%  damp simple.jsdebugger.reload.DAMP windows7-32-shippable opt e10s stylo             187.65 -> 196.51
  4%  damp complicated.jsdebugger.open.DAMP windows7-32-shippable opt e10s stylo          1,080.07 -> 1,124.36
  4%  damp custom.jsdebugger.open.DAMP windows7-32-shippable opt e10s stylo               1,006.02 -> 1,046.21
  4%  damp custom.jsdebugger.reload.DAMP windows7-32-shippable opt e10s stylo             863.44 -> 895.69
  2%  damp windows7-32-shippable opt e10s stylo                                           189.46 -> 193.28

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5656e43f9b43f912e7f71a683504bddcc24aa757&tochange=9c09f4d18f8a55c420deb37a5e3775a9e4fc9c1b

It's very likely that this regression is coming from enabling event listener breakpoints in Bug 1560571

Priority: -- → P2
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Whiteboard: [debugger-mvp]
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f217da5d73a7
Fix perf regression from Event listener breakpoints. r=loganfsmyth
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressions: 1565485

Please request approval on this and bug 1565485 when you get a chance.

Beta/Release Uplift Approval Request

  • User impact if declined: debugger will be significantly slower
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1565485
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): it only affects the debugger
  • String changes made/needed:
Flags: needinfo?(jlaster)
Attachment #9081295 - Flags: approval-mozilla-beta?
Attachment #9075789 - Flags: approval-mozilla-beta?
Attachment #9075789 - Flags: approval-mozilla-beta?
Comment on attachment 9081295 [details] [diff] [review]
beta-perf-v1.patch

Fixes a perf regression introduced in Fx69. Approved for 69.0b9.
Attachment #9081295 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.