Closed
Bug 1560956
Opened 5 years ago
Closed 5 years ago
[raptor][logger] RaptorLogger class - should not inherit from ProxyLogger
Categories
(Testing :: Raptor, defect, P1)
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: marauder, Assigned: marauder)
Details
Attachments
(1 file)
Assignee | ||
Comment 1•5 years ago
|
||
I have created this bug to address whimboo's comment from this patch:
https://phabricator.services.mozilla.com/D32984
"In such a case we shouldn't have subclassed ProxyLogger at all. It goes against inheritance. So given that these patches already landed, please file a follow-up to get this reverted."
Assignee | ||
Comment 2•5 years ago
|
||
RaptorLogger class is using object composition to create its logger field.
Because the inheritance is not used to achieve that, there is no need to extend ProxyLogger class.
Updated•5 years ago
|
Priority: -- → P1
Pushed by fstrugariu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b84d8a51e383 RaptorLogger class should not inherit from ProxyLogger r=perftest-reviewers,sparky
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•