Closed Bug 1560979 Opened 6 months ago Closed 5 months ago

MediaStreamTrack-MediaElement-disabled-video-is-black.https.html fails

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

67 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

Details

Attachments

(1 file)

We're permanently failing MediaStreamTrack-MediaElement-disabled-video-is-black.https.html.

I believe we render the right thing, so I'll look deeper into whether this is just a video-element-to-canvas thing, or something bigger.

It looks like we render black (it appears black to the user) but after drawImage() the canvas is transparent black (nothing was drawn?). This is the bug.

Ah, the test checks every pixel of the video element, and our disabled images are just 1x1, which the drawImage code does not scale up to the image's intrinsic size. We fail on "pixel #4" which is really pixel #2, because it counts all four components (0=R, 1=G, 2=B, 3=A) for each pixel.

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ea355821ea8d
Account for video element's intrinsic size in CanvasRenderingContext2D::DrawImage. r=jib,lsalzman
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.