Closed Bug 1561073 Opened 8 months ago Closed 8 months ago

powerPreference 'default' => 'low-power' if Canvas element has no parent

Categories

(Core :: Canvas: WebGL, enhancement, P1)

Unspecified
All
enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jgilbert
Priority: -- → P1
Summary: powerPreference 'default to low-power → powerPreference 'default' => 'low-power' if Canvas element has no parent
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd8a279979b3
powerPreference 'default' => 'low-power' if Canvas element has no parent. r=jrmuizel
Blocks: 1561124

Backed out changeset bd8a279979b3 (bug 1561073) for crashtests failures at obj-firefox/dist/include\mozilla/RefPtr.h

Backout: https://hg.mozilla.org/integration/autoland/rev/11921e0666e813701281ddf994492598788a9237

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=253213284&revision=bd8a279979b3969d4d8a6dd3d155df5df4bf7a3e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253213284&repo=autoland&lineNumber=10889

00:17:20 INFO - REFTEST TEST-START | file:///Z:/task_1561418154/build/tests/reftest/tests/dom/canvas/crashtests/1443671.html
00:17:20 INFO - REFTEST INFO | SET PREFERENCE pref(gfx.offscreencanvas.enabled,true)
00:17:20 INFO - REFTEST TEST-LOAD | file:///Z:/task_1561418154/build/tests/reftest/tests/dom/canvas/crashtests/1443671.html | 397 / 3765 (10%)
00:17:20 INFO - ++DOMWINDOW == 130 (0CB8C800) [pid = 3340] [serial = 1567] [outer = 090373A0]
00:17:20 INFO - Assertion failure: mRawPtr != nullptr (You can't dereference a NULL RefPtr with operator->().), at z:/build/build/src/obj-firefox/dist/include\mozilla/RefPtr.h:297
00:17:43 INFO - #01: mozilla::WebGLContext::SetDimensions(int,int) [dom/canvas/WebGLContext.cpp:860]
00:17:43 INFO -
00:17:43 INFO - #02: mozilla::dom::CanvasRenderingContextHelper::UpdateContext(JSContext *,JS::Handle<JS::Value>,mozilla::ErrorResult &) [dom/canvas/CanvasRenderingContextHelper.cpp:216]
00:17:43 INFO -
00:17:43 INFO - #03: mozilla::dom::CanvasRenderingContextHelper::GetContext(JSContext *,nsTSubstring<char16_t> const &,JS::Handle<JS::Value>,mozilla::ErrorResult &) [dom/canvas/CanvasRenderingContextHelper.cpp:175]
00:17:43 INFO -
00:17:43 INFO - #04: mozilla::dom::OffscreenCanvas::GetContext(JSContext *,nsTSubstring<char16_t> const &,JS::Handle<JS::Value>,mozilla::ErrorResult &) [dom/canvas/OffscreenCanvas.cpp:115]
00:17:43 INFO -
00:17:43 INFO - #05: static bool mozilla::dom::OffscreenCanvas_Binding::getContext(struct JSContext *, class JS::Handle<JSObject *>, class mozilla::dom::OffscreenCanvas *, const class JSJitMethodCallArgs & const) [s3:gecko-generated-sources:25d20d2bc7232ae787616f4d1ce8317010d18645ae09bf9a3f33f2f59adf1a48573bc8d18bbe185d1ad81f8db63f051e782e69b59bbabecb72968c03d6b414cd/dom/bindings/OffscreenCanvasBinding.cpp::202]
00:17:43 INFO -
00:17:43 INFO - #06: mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext *,unsigned int,JS::Value *) [dom/bindings/BindingUtils.cpp:3171]
00:17:43 INFO -
00:17:43 INFO - #07: CallJSNative(JSContext ,bool ()(JSContext *,unsigned int,JS::Value *),JS::CallArgs const &) [js/src/vm/Interpreter.cpp:448]
00:17:43 INFO -
00:17:43 INFO - #08: js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [js/src/vm/Interpreter.cpp:540]
00:17:43 INFO -
00:17:43 INFO - #09: static bool InternalCall(struct JSContext *, const class js::AnyInvokeArgs & const) [js/src/vm/Interpreter.cpp:595]
00:17:43 INFO -
00:17:43 INFO - #10: static bool Interpret(struct JSContext *, class js::RunState & const) [js/src/vm/Interpreter.cpp:0]
00:17:43 INFO -
00:17:43 INFO - #11: js::RunScript(JSContext *,js::RunState &) [js/src/vm/Interpreter.cpp:425]
00:17:43 INFO -

INFO - REFTEST PROCESS-CRASH | file:///Z:/task_1561418154/build/tests/reftest/tests/dom/canvas/crashtests/1443671.html | application crashed [@ mozilla::WebGLContext::CreateAndInitGL(bool,std::vector<mozilla::WebGLContext::FailureReason,std::allocator<mozilla::WebGLContext::FailureReason> > * const)]
00:18:07 INFO - Crash dump filename: c:\users\task_1561418154\appdata\local\temp\tmpn2kkti.mozrunner\minidumps\93ade381-5c81-4353-8540-357d1cde3694.dmp
00:18:07 INFO - Operating system: Windows NT
00:18:07 INFO - 6.1.7601 Service Pack 1
00:18:07 INFO - CPU: x86
00:18:07 INFO - GenuineIntel family 6 model 63 stepping 2
00:18:07 INFO - 8 CPUs
00:18:07 INFO -
00:18:07 INFO - GPU: UNKNOWN
00:18:07 INFO -
00:18:07 INFO - Crash reason: EXCEPTION_BREAKPOINT
00:18:07 INFO - Crash address: 0x59596990
00:18:07 INFO - Assertion: Unknown assertion type 0x00000000
00:18:07 INFO - Process uptime: 73 seconds
00:18:07 INFO -
00:18:07 INFO - Thread 0 (crashed)
00:18:07 INFO - 0 xul.dll!mozilla::WebGLContext::CreateAndInitGL(bool,std::vector<mozilla::WebGLContext::FailureReason,std::allocator<mozilla::WebGLContext::FailureReason> > * const) [WebGLContext.cpp:bd8a279979b3969d4d8a6dd3d155df5df4bf7a3e : 641 + 0x5a]
00:18:07 INFO - eip = 0x59596990 esp = 0x0020e4dc ebp = 0x0020e52c ebx = 0x0cb90100
00:18:07 INFO - esi = 0x0cb97400 edi = 0x0cb97400 eax = 0x730e26dc ecx = 0x00000129
00:18:07 INFO - edx = 0x00000049 efl = 0x00000202
00:18:07 INFO - Found by: given as instruction pointer in context
00:18:07 INFO - 1 xul.dll!mozilla::WebGLContext::SetDimensions(int,int) [WebGLContext.cpp:bd8a279979b3969d4d8a6dd3d155df5df4bf7a3e : 860 + 0x7]
00:18:07 INFO - eip = 0x595970ae esp = 0x0020e534 ebp = 0x0020e5a0 ebx = 0x0cb97400
00:18:07 INFO - esi = 0x0000012c edi = 0x00000096
00:18:07 INFO - Found by: call frame info
00:18:07 INFO - 2 xul.dll!mozilla::dom::CanvasRenderingContextHelper::UpdateContext(JSContext *,JS::Handle<JS::Value>,mozilla::ErrorResult &) [CanvasRenderingContextHelper.cpp:bd8a279979b3969d4d8a6dd3d155df5df4bf7a3e : 216 + 0xc]
00:18:07 INFO - eip = 0x59572c1c esp = 0x0020e5a8 ebp = 0x0020e5d0 ebx = 0x09099b78
00:18:07 INFO - esi = 0x09099b70 edi = 0x0cb97400
00:18:07 INFO - Found by: call frame info
00:18:07 INFO - 3 xul.dll!mozilla::dom::CanvasRenderingContextHelper::GetContext(JSContext *,nsTSubstring<char16_t> const &,JS::Handle<JS::Value>,mozilla::ErrorResult &) [CanvasRenderingContextHelper.cpp:bd8a279979b3969d4d8a6dd3d155df5df4bf7a3e : 174 + 0xc]
00:18:07 INFO - eip = 0x59572929 esp = 0x0020e5d8 ebp = 0x0020e608 ebx = 0x09099b70
00:18:07 INFO - esi = 0x0020e634 edi = 0x5dcf5350
00:18:07 INFO - Found by: call frame info
00:18:07 INFO - 4 xul.dll!mozilla::dom::OffscreenCanvas::GetContext(JSContext *,nsTSubstring<char16_t> const &,JS::Handle<JS::Value>,mozilla::ErrorResult &) [OffscreenCanvas.cpp:bd8a279979b3969d4d8a6dd3d155df5df4bf7a3e : 112 + 0x16]
00:18:07 INFO - eip = 0x5957ba14 esp = 0x0020e610 ebp = 0x0020e65c ebx = 0x0020e680
00:18:07 INFO - esi = 0x0020e6bc edi = 0x09099b70
00:18:07 INFO - Found by: call frame info
00:18:07 INFO - 5 xul.dll!static bool mozilla::dom::OffscreenCanvas_Binding::getContext(struct JSContext *, class JS::Handle<JSObject *>, class mozilla::dom::OffscreenCanvas *, const class JSJitMethodCallArgs & const) [OffscreenCanvasBinding.cpp: : 201 + 0x12]
00:18:07 INFO - eip = 0x5898404a esp = 0x0020e664 ebp = 0x0020e75c ebx = 0x0020e77c
00:18:07 INFO - esi = 0x0020e680 edi = 0x09099b70
00:18:07 INFO - Found by: call frame info

Flags: needinfo?(jgilbert)
Flags: needinfo?(jgilbert)
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/001b4c1fa4f7
powerPreference 'default' => 'low-power' if Canvas element has no parent. r=jrmuizel
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
See Also: → 1562812
You need to log in before you can comment on or make changes to this bug.