Closed Bug 1561144 Opened 2 years ago Closed 2 years ago

Use 3-tier PGO for Windows 32-bit builds

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(3 files)

Bug 1557785 will switch Windows 64-bit builds over to the 3-tier model, but we still need to convert the 32-bit builds. This should be simple since all the configure and Makefile issues are addressed in that bug.

Note that I tried to share the 64-bit profile and use it in a 32-bit profile-use build, but there were a few talos regressions. So it seems prudent to continue to have a full separate stack of profile-generate, run task, and profile-use builds.

(In reply to Michael Shal [:mshal] from comment #0)

Note that I tried to share the 64-bit profile and use it in a 32-bit
profile-use build, but there were a few talos regressions. So it seems
prudent to continue to have a full separate stack of profile-generate, run
task, and profile-use builds.

Yeah that's not surprising; mangled names are going to be so different between Win32 and Win64 that the optimizer is unlikely to find any profile data that it needs.

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6eb7b9e1795f
Add win32 PGO-instrumented task; r=tomprince
https://hg.mozilla.org/integration/autoland/rev/efece522190a
Add win32 generate profile task; r=tomprince
https://hg.mozilla.org/integration/autoland/rev/16eb3295bc71
Enable 3-tier PGO on win32 builds; r=tomprince
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.