Closed Bug 1561183 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17376 - [css-text] Hang sequence of white spaces that may otherwise overflow

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17376 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17376
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:

[css-text] Hang sequence of white spaces that may otherwise overflow

When a item overflows, we try to find a safe position that breaks the
item to avoid it. However, we should consider that sequence of white
space characters might have to be hanged, honoring the white-space
property.

We manage that case correctly the overflowing text is part of a
previously broken (kSuccess result from BreakText) item. However, if
there is an item that starts with a white space sequence and it
overflows, we always try to break it instead of hanging.

This patch address the issue by detecting such overflowing item,
verifying that it has a white space sequence and the white-space
property's value allows hanging it. In that case, we should rewind
the iterator, so that the further item_results are removed and skip
the rest of the overflowing handling logic.

Bug: 973358
Change-Id: I0e2ad5c5740f4ce592dd83b8ff3d224dbb45117e
Reviewed-on: https://chromium-review.googlesource.com/1662451
WPT-Export-Revision: c2edff84a5a376e3a113d9f1604c01a0c2ce3e08

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/1a70ce4c3498 [wpt PR 17376] - [css-text] Hang sequence of white spaces that may otherwise overflow, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1a70ce4c3498

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.