1561189 - [wpt-sync] Sync PR 17465 - Revert "Insert a generated item after preserved spaces following a forced break"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 17465 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17465
Details from upstream follow.

Dan Beam <[e-mail]> wrote:

Revert "Insert a generated item after preserved spaces following a forced break"

This reverts commit 6b0ca8ce33e71d570fce11ae6fb5f898ddf053e4.

Reason for revert:

Broke external/wpt/css/css-text/word-break/word-break-break-all-004.html on many Mac bots:

https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/44291
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/39449
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/24278
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/14909
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/16025

Original change's description:

Insert a generated item after preserved spaces following a forced break

We already had to implement a special logic to deal with leading
preserved white spaces due some optimizations we have in the line
breaking code to give always breaking opportunities before spaces.

However, the presence of forced breaks may cause some of the following
spaces becoming leading preserved spaces in the next line.

This patch applies the same logic we had for such leading spaces at
the text's first line. It also needs to define additional cases in the
function that evaluates the need of adding these generated breaking
opportunity items.

Bug: 976195
Change-Id: If39e7ba8a535c15d33d6021c6cd04da9590b1131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667305
Commit-Queue: Javier Fernandez \<[e-mail]>
Reviewed-by: Koji Ishii \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#671656}

TBR=[e-mail],[e-mail]

Change-Id: I418bb0d30fce7f9ac5724f76c0a854bcb070aa5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 976195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674249
Reviewed-by: Dan Beam \<[e-mail]>
Commit-Queue: Dan Beam \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#671703}

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad447c4af36e
[wpt PR 17465] - Revert "Insert a generated item after preserved spaces following a forced break", a=testonly

Comment 2

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ad447c4af36e