1561245 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.CrashHandlerService.onStartCommand(CrashHandlerService.java)]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

This bug is for crash report bp-09ed45ac-8204-4792-bae2-db3400190619.

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.gecko.CrashHandlerService.onStartCommand(CrashHandlerService.java:26)
	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:2764)
	at android.app.ActivityThread.access$2100(ActivityThread.java:144)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1343)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:212)
	at android.app.ActivityThread.main(ActivityThread.java:5151)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:877)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:693)
	at dalvik.system.NativeStart.main(Native Method)

There are 27 crashes (from 24 installations) in 68.0b11 with buildid 20190617221408. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1550291.

[1] https://hg.mozilla.org/releases/mozilla-beta/rev?node=22cfa63e8563

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1561245 - Add a null check for the received Intent; r?VladBaicu

According to the documentation -
https://developer.android.com/reference/android/app/Service.html
"The Intent supplied to Context.startService(Intent) may be null if the service
is being restarted after its process has gone away, and it had previously
returned anything except START_STICKY_COMPATIBILITY."

We will ignore the case when the system restarts our Service as we only expect
it to be properly started by us, in the event of a crash.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd51e03eae41
Add a null check for the received Intent; r=VladBaicu

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/cd51e03eae41

Comment 4

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We will want to uplift this Fennec crash fix to the ESR 68 branch for the Fennec 68.1 release.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9073815 [details]
Bug 1561245 - Add a null check for the received Intent; r?VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch increases the stability of our Crash Reporter which previously may have caused crashes with seemingly no clear cause.
• User impact if declined: The app may crash.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change is not risky as it involves a simple null check.
• String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

• User impact if declined: The app may crash.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change is not risky as it involves a simple null check.
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Seems safe enough for 68.0.

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7d0117af32b0