1561270 - Some keys in Dutch localized Thunderbird 68 open Thunderbird support page in Firefox

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: groupedBySort.xpi

I have a very simple bootstrapped add-on which adds three keyboard shortcuts to the View > Sort by functions Threaded, Unthreaded and Grouped By Sort. This add-on works normally in TB68 en-US, but in Dutch version it somehow doesn't perform the function I call, but opens app.support.baseURL in Firefox.
I have also tested this in localized en-GB and de versions, but there it works normally. I cannot figure out what is different with Dutch localized version. It fails in Dutch localized version if you add is as languagepack, but also if you do a clean install of Dutch Thunderbird.
I've created an even simpler proof of concept add-on, which doesn't use localization and only (re)adds the G-key, which was removed by bug 275871.

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

Although the proof of concept xpi is bootstrapped, the key only takes effect after a restart of Thunderbird. Not sure it that's a bug too, but just so you know if you want to verify this bug…

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

I now notice that the keys ',' and '.' (comma and dot) also redirect to the support page, even with Add-ons disabled, so this might not be an extension problem after all. It works correctly in safe mode though…

Comment 3

[Onno Ekker [:nONoNonO UTC+1]]

This also happens in a new install of Thunderbird 68.0b5 32-bit nl (20190715220659) with a new profile. Immediately after starting up, when I press a key that is not assigned, e.g. 'd', either in the 3-pane window or in a stand-alone message window, the support page opens.
I have also verified with en-GB and German versions, but they don't seem to have this problem, but I cannot explain why this only happens for some locale builds.

Comment 4

[Wayne Mery (:wsmwk)]

Sorry, I missed your report in the etherpad. Is this issue new to beta? Or just newly detected?

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

I detected it with my bootstrapped add-on, which only works in TB68, but now I can reproduce also without the add-on, so I'll see if I can find a regression range with mozregression-gui for Dutch version. TB60.* works as expected.

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Last known good: 2019-05-20 10:41:36 (68.0a1)
First known bad: 2019-05-20 14:35:05 (69.0a1)

Comment 7

[Wayne Mery (:wsmwk)]

https://hg.mozilla.org/comm-central/pushloghtml?startdate=2019-05-20+10%3A41%3A36&enddate=2019-05-20+14%3A35%3A05
https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2019-05-20+10%3A41%3A36&enddate=2019-05-20+14%3A35%3A05

Comment 8

[Onno Ekker [:nONoNonO UTC+1]]

I see Dutch has a wrong key for productHelp.commandkey, VK-F1 instead of VK_F1. Maybe that is undefined and defaults to nothing?

Comment 9

[Onno Ekker [:nONoNonO UTC+1]]

Yup, that's why it goes to the Help page :-)

Comment 10

[Onno Ekker [:nONoNonO UTC+1]]

https://hg.mozilla.org/l10n-central/nl/rev/b4266271e351b3ed9b05439cf62ba0619226cd7f
This should definitely go into beta :-|

Comment 11

[Onno Ekker [:nONoNonO UTC+1]]

So what do we do with this bug? Leave here and resolve Invalid?
Change product/component to Mozilla Localizetion / nl Dutch and resolve Fixed?

Comment 12

[Jorg K (CEST = GMT+2)]

The latter. When we build 68 ESR, we make sure your changeset is included.