1561392 - "categories.map is not a function" error is breaking remote debugger with Event Breakpoints enabled

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Thomas Wisniewski [:twisniewski]]

In today's nightly build, I see the following error logged to my browser console when I try to access any remote devtools debugger panel (which becomes blank):

TypeError: "categories.map is not a function"
    render resource://devtools/client/debugger/src/components/SecondaryPanes/EventListeners.js:153
    finishClassComponent resource://devtools/client/shared/vendor/react-dom.js:10332
    updateClassComponent resource://devtools/client/shared/vendor/react-dom.js:10295
    beginWork resource://devtools/client/shared/vendor/react-dom.js:10894
    performUnitOfWork resource://devtools/client/shared/vendor/react-dom.js:12713
    workLoop resource://devtools/client/shared/vendor/react-dom.js:12730
    renderRoot resource://devtools/client/shared/vendor/react-dom.js:12770
    performWorkOnRoot resource://devtools/client/shared/vendor/react-dom.js:13359
    performWork resource://devtools/client/shared/vendor/react-dom.js:13281
    performSyncWork resource://devtools/client/shared/vendor/react-dom.js:13253
    requestWork resource://devtools/client/shared/vendor/react-dom.js:13153
    scheduleWork$1 resource://devtools/client/shared/vendor/react-dom.js:13022
    enqueueSetState resource://devtools/client/shared/vendor/react-dom.js:8845
    setState React
    Redux 8
    waitUntilService resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:65
    promiseMiddleware resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:31
    context resource://devtools/client/debugger/src/actions/utils/middleware/context.js:33
    thunk resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:21
    dispatch Redux
    getEventListenerBreakpointTypes resource://devtools/client/debugger/src/actions/event-listeners.js:88
react-dom.js:11273:13

When I set devtools.debugger.features.event-listeners-breakpoints to false the problem goes away, so I'm guessing it's related to bug 1526082.

Comment 1

[Logan Smyth [:loganfsmyth]]

Out of curiosity, does the remote device have the newest nightly too, or does it have an older version of Firefox?

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1561392 - Handle backward-compat for new event-breakpoint implementation. r=davidwalsh

Comment 3

[Thomas Wisniewski [:twisniewski]]

I'm not personally sure, but I'm guessing not? It's the latest Fenix nightly on the Play Store (1.0.1926, Tuesday 6/25, 68.0-20190612114833)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/308ea5eaadf1
Handle backward-compat for new event-breakpoint implementation. r=davidwalsh

Comment 5

[Logan Smyth [:loganfsmyth]]

Perfect. The main Firefox Nightly is 69, which is where this logic has just landed, so talking to 68 won't quite work. The patch I've attached here should resolve this so things don't fail.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/308ea5eaadf1