Closed Bug 1561410 Opened 5 years ago Closed 5 years ago

OSX Mojave (10.14) - ThreadPool.ShutdownWithTimeout | Expected equality of these values:

Categories

(Core :: XPCOM, defect, P5)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox-esr68 --- fixed
firefox69 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: froydnj)

References

Details

Attachments

(1 file)

Bug 1561410 - modify TestThreadPool to be more robust with bad timekeeping; r=erahm
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr68+
Details | Review

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=253399507&repo=try
Full log: https://queue.taskcluster.net/v1/task/apABcBWtSDqXMLUgS_b97g/runs/0/artifacts/public/logs/live_backing.log

Platform: macosx1014-mojave
Test: gtest

Context:
19:17:48 INFO - TEST-START | ThreadPool.ShutdownWithTimeout
19:17:48 INFO - ###(0) running from thread: 0x10bc3f970
19:17:48 INFO - ###(1) running from thread: 0x10bc3fbd0
19:17:48 INFO - ###(2) running from thread: 0x10bc3fd00
19:17:48 INFO - ###(3) running from thread: 0x10bc3fe30
19:17:48 INFO - ###(2) exiting from thread: 0x10bc3fd00
19:17:48 INFO - ###(3) exiting from thread: 0x10bc3fe30
19:17:48 INFO - ###(1) exiting from thread: 0x10bc3fbd0
19:17:48 WARNING - TEST-UNEXPECTED-FAIL | ThreadPool.ShutdownWithTimeout | Expected equality of these values:
19:17:48 INFO - Task::sCount
19:17:48 INFO - Which is: 3
19:17:48 INFO - 4 @ /builds/worker/workspace/build/src/xpcom/tests/gtest/TestThreadPool.cpp:140
19:17:48 INFO - ###(0) running from thread: 0x10bc3fbd0
19:17:48 INFO - ###(1) running from thread: 0x10bc3fd00
19:17:48 INFO - ###(2) running from thread: 0x10bc3fe30
19:17:48 INFO - ### running from thread that never ends: 0x10bc3ff60
19:17:48 INFO - ###(0) exiting from thread: 0x10bc3f970
19:17:49 INFO - ###(2) exiting from thread: 0x10bc3fe30
19:17:49 INFO - ###(0) exiting from thread: 0x10bc3fbd0
19:17:49 INFO - ###(1) exiting from thread: 0x10bc3fd00
19:17:49 WARNING - TEST-UNEXPECTED-FAIL | ThreadPool.ShutdownWithTimeout | Expected equality of these values:
19:17:49 INFO - Task::sCount
19:17:49 INFO - Which is: 4
19:17:49 INFO - 3 @ /builds/worker/workspace/build/src/xpcom/tests/gtest/TestThreadPool.cpp:164
19:17:49 WARNING - TEST-UNEXPECTED-FAIL | ThreadPool.ShutdownWithTimeout | test completed (time: 1317ms)
19:17:49 INFO - TEST-START | ThreadPool.ShutdownWithTimeoutThenSleep
19:17:49 INFO - ###(0) running from thread: 0x10bc3f970
19:17:49 INFO - ###(1) running from thread: 0x10bc3fbd0
19:17:49 INFO - ###(2) running from thread: 0x10bc3fd00
19:17:49 INFO - ### running from thread that sleeps for 400ms: 0x10bc3fe30
19:17:49 INFO - ###(0) exiting from thread: 0x10bc3f970
19:17:49 INFO - ###(2) exiting from thread: 0x10bc3fd00
19:17:50 INFO - ###(1) exiting from thread: 0x10bc3fbd0
19:17:50 INFO - ### thread awoke from long sleep: 0x10bc3fe30
19:17:50 INFO - TEST-PASS | ThreadPool.ShutdownWithTimeoutThenSleep | test completed (time: 508ms)

:froydnj - this test is permanently failing on macosx1014-64/debug only. Would you be able to take a look, or direct ni to someone who may be able to comment on this failure? Depending on the timeline of a patch it may be necessary to disable the test temporarily.

Flags: needinfo?(nfroyd)

I would try raising the timeout here:

https://searchfox.org/mozilla-central/source/xpcom/tests/gtest/TestThreadPool.cpp#138-140

Maybe along with other calls to ShutdownWithTimeout in that file, if you are having problems with failures there.

Flags: needinfo?(nfroyd)

:froydnj - I have tried your suggestion in the following push: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=62aa25ab46c481f28b5f30fd26814dd3f17dfe5b

It seems to have simply pushed the equality test failure to the next test, which is ShutdownWithTimeoutThenSleep.

Giving each logical test its own counter variable will help tests to not
interfere with each other. We also make one infinite looping thread
exit so we're not chewing CPU after these tests finish.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddc124407164
modify TestThreadPool to be more robust with bad timekeeping; r=KrisWright

https://hg.mozilla.org/mozilla-central/rev/ddc124407164

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → nfroyd

Comment on attachment 9075224 [details]
Bug 1561410 - modify TestThreadPool to be more robust with bad timekeeping; r=erahm

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: testonly change to get tests running on osx 10.14 instead of 10.10
  • User impact if declined:
  • Fix Landed on Version: 69
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String or UUID changes made by this patch:
Attachment #9075224 - Flags: approval-mozilla-esr68?

Comment on attachment 9075224 [details]
Bug 1561410 - modify TestThreadPool to be more robust with bad timekeeping; r=erahm

Test-only change needed to run tests on OSX 10.14. Approved for 68.1esr.

Attachment #9075224 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Edwin, could you please take a look over bug 1565769, as Nathan is away till the 21st, it looks similar if not the same as this one. Thank you.

Flags: needinfo?(egao)
See Also: → 1565769

I took a look at the patch and the code, but I'm not a C++ developer so I think it may be best to wait for :froydnj to return.

Flags: needinfo?(egao)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: