Closed Bug 1561457 Opened 5 years ago Closed 5 years ago

Intermittent [tier 2] python/mozversioncontrol/test/test_push_to_try.py::test_push_to_try[git] TEST-UNEXPECTED-FAIL

Categories

(Developer Infrastructure :: Try, defect, P5)

Product:
Developer Infrastructure
Component:
Try
Type:
defect

Tracking

(firefox-esr60 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dbaron)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=253405393&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/BIJRIkiST_uWQjGVoDYGGA/runs/0/artifacts/public/logs/live_backing.log

[task 2019-06-25T20:17:38.034Z] 0:25.45 python/mozversioncontrol/test/test_push_to_try.py::test_push_to_try[git] TEST-UNEXPECTED-FAIL
[task 2019-06-25T20:17:38.034Z] 0:25.45 python/mozversioncontrol/test/test_push_to_try.py::test_push_to_try[hg] PASSED
[task 2019-06-25T20:17:38.035Z] 0:25.45 python/mozversioncontrol/test/test_push_to_try.py::test_push_to_try_missing_extensions[git] PASSED
[task 2019-06-25T20:17:38.035Z] 0:25.45 python/mozversioncontrol/test/test_push_to_try.py::test_push_to_try_missing_extensions[hg] PASSED
[task 2019-06-25T20:17:38.035Z] 0:25.45
[task 2019-06-25T20:17:38.036Z] 0:25.45 =================================== FAILURES ===================================
[task 2019-06-25T20:17:38.036Z] 0:25.45 ____________________________ test_push_to_try[git] _____________________________
[task 2019-06-25T20:17:38.036Z] 0:25.45
[task 2019-06-25T20:17:38.036Z] 0:25.45 repo = local('/tmp/pytest-of-worker/pytest-3/test_push_to_try_git_0/repo')
[task 2019-06-25T20:17:38.037Z] 0:25.45 monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f57db26ff50>
[task 2019-06-25T20:17:38.037Z] 0:25.45
[task 2019-06-25T20:17:38.038Z] 0:25.45 def test_push_to_try(repo, monkeypatch):
[task 2019-06-25T20:17:38.038Z] 0:25.45 commit_message = "commit message"
[task 2019-06-25T20:17:38.038Z] 0:25.45 vcs = get_repository_object(repo.strpath)
[task 2019-06-25T20:17:38.039Z] 0:25.45
[task 2019-06-25T20:17:38.039Z] 0:25.45 captured_commands = []
[task 2019-06-25T20:17:38.039Z] 0:25.45
[task 2019-06-25T20:17:38.039Z] 0:25.45 def fake_run(*args, **kwargs):
[task 2019-06-25T20:17:38.040Z] 0:25.45 captured_commands.append(args[0])
[task 2019-06-25T20:17:38.040Z] 0:25.45
[task 2019-06-25T20:17:38.040Z] 0:25.45 monkeypatch.setattr(subprocess, 'check_output', fake_run)
[task 2019-06-25T20:17:38.040Z] 0:25.45 monkeypatch.setattr(subprocess, 'check_call', fake_run)
[task 2019-06-25T20:17:38.041Z] 0:25.45
[task 2019-06-25T20:17:38.041Z] 0:25.45 vcs.push_to_try(commit_message)
[task 2019-06-25T20:17:38.041Z] 0:25.45 tool = vcs._tool
[task 2019-06-25T20:17:38.041Z] 0:25.45
[task 2019-06-25T20:17:38.041Z] 0:25.45 if repo.vcs == 'hg':
[task 2019-06-25T20:17:38.042Z] 0:25.45 expected = [
[task 2019-06-25T20:17:38.042Z] 0:25.45 (tool, 'push-to-try', '-m', commit_message),
[task 2019-06-25T20:17:38.042Z] 0:25.45 (tool, 'revert', '-a'),
[task 2019-06-25T20:17:38.043Z] 0:25.45 ]
[task 2019-06-25T20:17:38.043Z] 0:25.45 else:
[task 2019-06-25T20:17:38.043Z] 0:25.45 expected = [
[task 2019-06-25T20:17:38.043Z] 0:25.45 (tool, 'cinnabar', '--version'),
[task 2019-06-25T20:17:38.043Z] 0:25.45 (tool, 'commit', '--allow-empty', '-m', commit_message),
[task 2019-06-25T20:17:38.044Z] 0:25.45 (tool, '-c', 'remote.try.url=hg::ssh://hg.mozilla.org/try',
[task 2019-06-25T20:17:38.044Z] 0:25.45 'push', 'try', '+HEAD:refs/heads/branches/default/tip'),
[task 2019-06-25T20:17:38.044Z] 0:25.46 (tool, 'reset', 'HEAD~'),
[task 2019-06-25T20:17:38.045Z] 0:25.46 ]
[task 2019-06-25T20:17:38.046Z] 0:25.46
[task 2019-06-25T20:17:38.047Z] 0:25.46 for i, value in enumerate(captured_commands):
[task 2019-06-25T20:17:38.048Z] 0:25.46 > assert value == expected[i]
[task 2019-06-25T20:17:38.048Z] 0:25.46 E AssertionError: assert ('/usr/bin/gi...y', '-m', ...) == ('/usr/bin/git...mmit message')
[task 2019-06-25T20:17:38.048Z] 0:25.46 E At index 1 diff: u'-c' != u'commit'
[task 2019-06-25T20:17:38.049Z] 0:25.46 E Left contains more items, first extra item: '-m'
[task 2019-06-25T20:17:38.049Z] 0:25.46 E Full diff:
[task 2019-06-25T20:17:38.050Z] 0:25.46 E + (u'/usr/bin/git', u'commit', u'--allow-empty', u'-m', u'commit message')
[task 2019-06-25T20:17:38.051Z] 0:25.46 E - (u'/usr/bin/git',
[task 2019-06-25T20:17:38.051Z] 0:25.46 E - u'-c',
[task 2019-06-25T20:17:38.052Z] 0:25.46 E - u'commit.gpgSign=false',
[task 2019-06-25T20:17:38.053Z] 0:25.46 E - u'commit',
[task 2019-06-25T20:17:38.054Z] 0:25.46 E - u'--allow-empty',
[task 2019-06-25T20:17:38.055Z] 0:25.47 E - u'-m',
[task 2019-06-25T20:17:38.055Z] 0:25.47 E - u'commit message')
[task 2019-06-25T20:17:38.056Z] 0:25.47
[task 2019-06-25T20:17:38.057Z] 0:25.47 /builds/worker/checkouts/gecko/python/mozversioncontrol/test/test_push_to_try.py:48: AssertionError
[task 2019-06-25T20:17:38.057Z] 0:25.47 ---------------------------- Captured stdout setup -----------------------------
[task 2019-06-25T20:17:38.058Z] 0:25.47 Initialized empty Git repository in /tmp/pytest-of-worker/pytest-3/test_push_to_try_git_0/repo/.git/
[task 2019-06-25T20:17:38.059Z] 0:25.47 [master (root-commit) 1a92b13] Initial commit
[task 2019-06-25T20:17:38.059Z] 0:25.47 2 files changed, 2 insertions(+)
[task 2019-06-25T20:17:38.060Z] 0:25.47 create mode 100644 bar
[task 2019-06-25T20:17:38.061Z] 0:25.47 create mode 100644 foo
[task 2019-06-25T20:17:38.061Z] 0:25.47 Branch master set up to track remote branch master from upstream.
[task 2019-06-25T20:17:38.062Z] 0:25.47 ---------------------------- Captured stderr setup -----------------------------
[task 2019-06-25T20:17:38.063Z] 0:25.47 From ../remoterepo
[task 2019-06-25T20:17:38.063Z] 0:25.47 * [new branch] master -> upstream/master
[task 2019-06-25T20:17:38.064Z] 0:25.48 ====================== 1 failed, 3 passed in 1.99 seconds ======================

Flags: needinfo?(dbaron)
Regressed by: 1515105

Patch is already awaiting review in bug 1515105.

https://hg.mozilla.org/mozilla-central/rev/d7a2d32cfb3e

Assignee: nobody → dbaron
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → unaffected
status-firefox69: --- → fixed
Flags: needinfo?(dbaron)
Resolution: --- → FIXED
Has Regression Range: --- → yes
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.