1561488 - Crash in [@ mozilla::dom::BrowserChild::RecvUIResolutionChanged]

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Matt Woodrow (:mattwoodrow)]

This bug is for crash report bp-8a956a9f-6615-44c8-b6ae-aae730190622.

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::BrowserChild::RecvUIResolutionChanged dom/ipc/BrowserChild.cpp:3139
1 xul.dll mozilla::dom::PBrowserChild::OnMessageReceived ipc/ipdl/PBrowserChild.cpp:5725
2 xul.dll mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:6512
3 xul.dll void mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2078
4 xul.dll nsresult mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1968
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1175
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
7 xul.dll void mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Looks like a nullptr crash, likely a regression from bug 1542664.

I got this to crash by dragging a window between monitors while a tab was still loading.

Comment 1

[Neha Kochar [:neha]]

Adding ni for Masayuki based on the possible regression cause by mattwoodrow.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, I just renamed GetDocument() to GetTopLevelDocument() around the crash point so that I don't think that this is my regression.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Even before the my patch landing, there is this bug (BrowserChild was renamed from TabChild).

Comment 4

[Neha Kochar [:neha]]

Matt, was this with fission enabled?

Comment 5

[Matt Woodrow (:mattwoodrow)]

No, this was not with fission enabled.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Fairly low volume on release and P3; marking fix-optional to remove this bug from weekly triage.

Comment 8

[Wayne Mery (:wsmwk)]

I've had a few tab crashes. One of them is bp-8f508965-f7b7-424d-96d5-f946d0190821 68.0.1

Comment 9

[Wayne Mery (:wsmwk)]

I opened weather.com, shortly after firefox an app/tab is slowing down the browser, I chose to not stop the tab, after a minute crash bp-81b5b9fe-3e9b-4d4f-99bd-d77430190915

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1561488 - null check document in RecvUIResolutionChanged and RecvThemeChanged, r=bdahl

These were the worrisome missing null checks I noticed, and crash-stat shows that there areactually crashes in these two places

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4d3b6aa5270
null check document in RecvUIResolutionChanged and RecvThemeChanged, r=bdahl

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d4d3b6aa5270