Closed Bug 1561506 Opened 5 years ago Closed 5 years ago

make GCParallelTask::startOrRunIfIdle safe when threads are disabled

Categories

(Core :: JavaScript: GC, task, P3)

Product:
Core
Component:
JavaScript: GC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: pbone, Assigned: pbone)

Details

Attachments

(1 file)

Bug 1561506 - Make startOrRunIfIdle safe when threads are disabled r=jonco
47 bytes, text/x-phabricator-request
Details | Review

GCParallelTask::startOrRunIfIdle asserts if it tries to start a thread but multi-threading is diabled. I have a patch that makes startOrRunIfIdle run the task on the main thread when threading is diabled. This simplifies its callsites.

Assignee: nobody → pbone
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11adb29b0bdc
Make startOrRunIfIdle safe when threads are disabled r=jonco

https://hg.mozilla.org/mozilla-central/rev/11adb29b0bdc

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: