Closed Bug 1561536 Opened 5 years ago Closed 5 years ago

Add new message schema and template type for feature callouts

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Iteration:
70.1 - Jul 8 - 21
Tracking Flags:
Tracking Status
firefox69 --- fixed
firefox70 --- verified

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5133
52 bytes, text/x-github-pull-request
Details | Review
  • New template type badge
  • Support for targeting UI elements:
    • content: {target: "whats-new-menu-button"} // element id
  • Support for actions
    • a notification message can specify an action with an id and possible arguments
    • the new badge hub that handles this message template can take the specified action similar to our template routing logic
Depends on: 1561537
Assignee: nobody → andrei.br92
Iteration: --- → 70.1 - Jul 8 - 21
Priority: -- → P2
Priority: P2 → P1
No longer depends on: 1561537
Blocks: 1565293

https://hg.mozilla.org/mozilla-central/rev/1f70de7f07a6

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

I have used the WHATS_NEW_BADGE_70 message in order to verify this issue as it the right template for this, is set up to target the whats-new-menu-button and has an action ""id": "show-whatsnew-button"". I have done this on the latest Nightly 70.0a1 (Build ID 20190714214027) on Windows 10, macOS 10.14, and Arch Linux 14.4.3.

Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
Regressions: 1571818
Regressions: 1575887
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: