Closed Bug 1561552 Opened 8 months ago Closed 8 months ago

Use :root instead of #main-window in browser/themes/windows/compacttheme.css

Categories

(Firefox :: Theme, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: dao, Assigned: umaralam48, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1554609 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/windows/compacttheme.css there are currently four selectors that should use :root instead of #main-window.

No longer depends on: 1554609

I would like to work on this bug.

(In reply to Mohd Umar Alam [:umaralam48] from comment #1)

I would like to work on this bug.

Go ahead! Let me know if you have questions.

Hi Dão Gottwald,

Can I work on this one?

(In reply to rajdgreat007 from comment #3)

Hi Dão Gottwald,

Can I work on this one?

I'm not sure... Mohd, are you working on this?

Flags: needinfo?(umaralam48)

Yes, I got occupied yesterday. Will submit the patch today.

Flags: needinfo?(umaralam48)

In that case I would suggest to assign this bug to avoid confusion. Right now it's showing as unassigned.

Assignee: nobody → umaralam48
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99213f6d510e
Use :root instead of #main-window in browser/themes/windows/compacttheme.css r=dao
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.