Use :root instead of #main-window in browser/themes/windows/compacttheme.css
Categories
(Firefox :: Theme, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: dao, Assigned: umaralam48, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1554609 +++
:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.
In browser/themes/windows/compacttheme.css there are currently four selectors that should use :root instead of #main-window.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
I would like to work on this bug.
|
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to Mohd Umar Alam [:umaralam48] from comment #1)
I would like to work on this bug.
Go ahead! Let me know if you have questions.
|
||
Comment 3•5 years ago
|
||
Hi Dão Gottwald,
Can I work on this one?
|
|
Reporter | |
Comment 4•5 years ago
|
||
(In reply to rajdgreat007 from comment #3)
Hi Dão Gottwald,
Can I work on this one?
I'm not sure... Mohd, are you working on this?
|
|
Assignee | |
Comment 5•5 years ago
|
||
Yes, I got occupied yesterday. Will submit the patch today.
|
|
||
Comment 6•5 years ago
|
||
In that case I would suggest to assign this bug to avoid confusion. Right now it's showing as unassigned.
|
|
Reporter | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 7•5 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99213f6d510e Use :root instead of #main-window in browser/themes/windows/compacttheme.css r=dao
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
Description
•