1561554 - Add telemetry events for notification badges

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

This should include events for when the badge appeared and when it was dismissed. We should verify if any other requirements are needed.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5176

Comment 2

[Andrei Oprea [:andreio]]

Attachment: data_review.txt

Similar to bug 1550065 for this feature we are sending out a telemetry ping (impression) at startup because that's how the FxA Accounts button notification currently works. This happens before the user has a chance to disable telemetry.
We want to keep this event because we are adding a new feature while at the same time replacing existing functionality. We want to ensure we are not regressing user experience.

Comment 3

[Chris H-C :chutten]

Comment on attachment 9078180 [details]
data_review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is part of Activity Stream so is documented in its [data_events.md](https://github.com/mozilla/activity-stream/blob/master/docs/v2-system-addon/data_events.md) file.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nan Jiang is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/16d1399f602c

Comment 5

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that IMPRESSION and CLICK events are collected when the toolbar button appears and when it is clicked on the latest Nightly 70.0a1 (Build ID 20190721215935) on Windows 10, macOS 10.14, and Arch Linux 4.14.3.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/feeaf170fca669a675eff2cb16bd56b0a329b508