1561571 - Make backfill action's add_args_to_command reusable and add support for string cmd parts

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, enhancement)

Description

[Bob Clary [:bc] (inactive)]

add_args_to_command is used in the backfill action to add arguments to a task's command.

It assumes for that

# windows has single cmd part as dict: 'task-reference', with long string

However in test isolation, the task's command for windows is a list consisting of a single long string.

I would like to reuse add_args_to_command in test isolation. To do this I would like to move it into util.py and add support for a string cmd part. I don't plan to move remove_args_from_command since I don't need it and changes there would require testing backfill on try which I don't know how to do.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1561571 - Make backfill action's add_args_to_command reusable and add support for string cmd parts, r=tomprince.

Depends on D36011

Comment 2

[Bob Clary [:bc] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=d7d799933a6d55de0a2a51d056289af6c0ec7c52

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ea815152fd7
Make backfill action's add_args_to_command reusable and add support for string cmd parts, r=tomprince.

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4ea815152fd7