1561657 - update text-underline-offset to meet resolved CSS spec issue 4021

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Charlie Marlow [:cmarlow]]

Per https://github.com/w3c/csswg-drafts/issues/4021, text-underline-offset needs to be updated so that positive lengths represent an outward movement of the underline, and negative lengths represent an inward movement

Comment 1

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1561657: fixed text-underline-offset so that positive lengths represent movement outwards from the text r?jfkthame

Comment 2

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1561657: fixed text-underline-offset so that positive lengths represent movement outwards from the text r?jfkthame

Comment 3

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1561657: fixed text-underline-offset so that positive lengths represent movement outwards from the text r?jfkthame

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4ffd7ba0442
fixed text-underline-offset so that positive lengths represent movement outwards from the text r=jfkthame

Comment 5

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1561657, Bug 1557857, Bug 1562704) for causing Wr permafailures in z:/build/build/src/layout/base/nsCSSFrameConstructor.cpp:3962 CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=fb8fbe6000f3ae72051a961f880f4a54299bf885&selectedJob=255307738

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255307738&repo=autoland&lineNumber=32915

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3035464a58af
Backed out 3 changesets (bug 1561657, bug 1557857, bug 1562704) for causing Wr permafailures in z:/build/build/src/layout/base/nsCSSFrameConstructor.cpp:3962 CLOSED TREE

Comment 7

[Daniel Holbert [:dholbert]]

I think bug 1557857 is the problematic commit - that's the one that introduces the test that has failures. So, I'm relanding the patch for this bug here (without bug 1557857).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d0f656aab84
fixed text-underline-offset so that positive lengths represent movement outwards from the text r=jfkthame

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6d0f656aab84

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17694 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged