1561660 - First run modal falls off the screen on some screen resolutions

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Aaron Benson]

Attachment: 04 join.PNG

We should decrease the top padding of the modal so that it is fully visible on the screen without having to scroll. As seen in the screenshot, the 'skip' call-to-action is not immediately visible.

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Localized text welcome screen

For default screen resolution on Mac High Sierra 1440 x 900 - for localized text, start browsing button falls off the screen and when scrolled shows in white text.

To test set intl.l10n.pseudo config to accented

This issue is replicable and more prominent for lower resolution 1280 x800 and below in all locales

Comment 2

[Ed Lee :Mardak]

Looks like bug 1552195 added a max-height which makes the modal shrink for smaller screens but the content still wants the larger/static height.

https://github.com/mozilla/activity-stream/pull/5060/files#diff-fac216c1e95fcb028bddb101b2324ba7L23

Comment 3

[Emily McMinn :emcminn]

So this can be fixed by setting the overflow for the modal - what would the preferred behavior be? Do we want the overflowing content to be hidden, or do we want to be able to scroll the modal content to see the button on small resolutions?

Comment 4

[Ed Lee :Mardak]

The previous behavior was to have the modal be the desired height and allow the user to scroll down. Sounds like aaron is suggesting we shift up the modal as well.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5154

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5155

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/1f70de7f07a6

Comment 9

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly 70.0a1 (Build ID 20190713215744) on Windows 10, macOS 10.14, and Arch Linux 14.4.3.
We're still going to have the "Start Browsing" button be under the view port on screen resolutions under 1000x800, but it's not cut off by the border.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to Beta or can this ride the trains?

Comment 11

[Kate Hudson :k88hudson]

What's your call on this one Aaron? Do we need to uplift

Comment 12

[Aaron Benson]

Given that this occurs in one of our more common screen resolutions, I think we should uplift.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 14

[Ed Lee :Mardak]

Attachment: Bug 1561660 - First run modal falls off the screen on some screen resolutions

Comment 15

[Kate Hudson :k88hudson]

Comment on attachment 9080183 [details]
Bug 1561660 - First run modal falls off the screen on some screen resolutions

Beta/Release Uplift Approval Request

• User impact if declined: First run "submit" button will not be visible on some screen resolutions; impacts quality of a user's first experience with Firefox
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Go to about:welcome

2. Try resizing the window to make it smaller vertically
3. Ensure you are still able to see the submit button when scrolling / it's not cut off by the border

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small style-only change
• String changes made/needed:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9080183 [details]
Bug 1561660 - First run modal falls off the screen on some screen resolutions

Fixes the first run "submit" button being cut off on some screen resolutions. Approved for 69.0b8.

Comment 17

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4871e8d95e3e

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out as https://hg.mozilla.org/releases/mozilla-beta/rev/b45f9de02a0f36724a7175c003e187b9e39918be and relanded with correct commit information: https://hg.mozilla.org/releases/mozilla-beta/rev/eb58740c994a323899cede3e07241c4ab8ee43c7

Comment 19

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (69.0b8 Build ID - 20190725174626) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, the "Submit" button is still visible after browser resize.