1561705 - Convert ChromePowers to use a regular SpecialPowers child actor

Status: RESOLVED FIXED

(Testing :: Mochitest, task, P3)

Description

[Kris Maglione [:kmag]]

This is a follow-up to bug 1541557.

Once SpecialPowers has been converted to a JSWindowActor, there should really be no reason not to just use it directly in chrome windows in the parent process, rather than maintaining a bunch of separate special cases for ChromePowers.js. Things should mostly Just Work.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 1 - Add JSWindowActor.actorCreated callback. r=jdai

The JSWindowActor constructor is called before the actor is fully initialized,
which means it can't do things like send messages or access its content
window. This patch adds a new callback which can do those things immediately
after the actor is created.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 2 - Use regular SpecialPowers actor for browser chrome tests. r=mccr8

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 3 - Get rid of remaining ChromePowers.js consumers. r=mccr8

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 4b - Merge SpecialPowersAPI.jsm and SpecialPowersChild.jsm. r=mccr8

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 5b - Merge SpecialPowersAPIParent.jsm and SpecialPowersParent.jsm. r=mccr8

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 4a - Remove SpecialPowersChild.jsm in preparation for merge with SpecialPowersAPI.jsm. r=mccr8

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Part 5a - Remove SpecialPowersParent.jsm in preparation for merge with SpecialPowersAPIParent.jsm. r=mccr8

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac3da20c687971c412d1164f08b17e0cccc5fbd5
Bug 1561705: Part 1 - Add JSWindowActor.actorCreated callback. r=jdai

https://hg.mozilla.org/integration/mozilla-inbound/rev/080ff558e41aad0cf05ca896c7f98bf4c9a2e7e9
Bug 1561705: Part 2 - Use regular SpecialPowers actor for browser chrome tests. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/cbe56a9fce5238a9bfdd0a2d226dc319380490b4
Bug 1561705: Part 3 - Get rid of remaining ChromePowers.js consumers. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c7d41b7baca9755a3a44f2c35c84b5c2352eb93
Bug 1561705: Part 4a - Remove SpecialPowersChild.jsm in preparation for merge with SpecialPowersAPI.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/dad7319f1f6cf3ebaa3f4f68fb3124492311a017
Bug 1561705: Part 4b - Merge SpecialPowersAPI.jsm and SpecialPowersChild.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/40a1794e0c0ec4d13533b2343a66448502e2b8b2
Bug 1561705: Part 5a - Remove SpecialPowersParent.jsm in preparation for merge with SpecialPowersAPIParent.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d136ac0e61af3b30eae8ad6a59730c2563aae1
Bug 1561705: Part 5b - Merge SpecialPowersAPIParent.jsm and SpecialPowersParent.jsm. r=mccr8

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/97fc86ccdbce
Fix ESlint failure

Comment 11

[Oana Pop-Rus]

Backed out 9 changesets (bug 1574296, bug 1561705) for devtools failures in browser_dbg-breaking-from-console.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=262406417&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=41b6d03a870caa7c4be2146ce8c8d84efdb20e79&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-e10s-2%2Cm%28dt2%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262406417&repo=mozilla-inbound&lineNumber=6053
Also: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262408611&repo=mozilla-inbound&lineNumber=31681

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d17f6700544d2ffbb52f5482e59e26805121f33d

Comment 12

[Kris Maglione [:kmag]]

Attachment: Bug 1561705: Follow-up: Disable leaky teests on linux debug. r=mccr8

Comment 13

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83744c33307eb2a12a61101fd87d4e553dfeaa9b
Bug 1561705: Part 1 - Add JSWindowActor.actorCreated callback. r=jdai

https://hg.mozilla.org/integration/mozilla-inbound/rev/8601c2fb82e48832bdc749a607e5009d0ea54c19
Bug 1561705: Part 2 - Use regular SpecialPowers actor for browser chrome tests. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/21aaa7a6c0f6f31157bed2ae459cb8a587fe95ab
Bug 1561705: Part 3 - Get rid of remaining ChromePowers.js consumers. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/8903ce08f03f9990a0b5ca15b96b96cd9d9356fd
Bug 1561705: Part 4a - Remove SpecialPowersChild.jsm in preparation for merge with SpecialPowersAPI.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cebcb44618aee3b57655ac45a76dcf13f6f9411
Bug 1561705: Part 4b - Merge SpecialPowersAPI.jsm and SpecialPowersChild.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/caa59e50a7b4db66d26564055e7437a85f535a2b
Bug 1561705: Part 5a - Remove SpecialPowersParent.jsm in preparation for merge with SpecialPowersAPIParent.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/72315ad35cbfe2afce8a22ee518bb5cfae1b2d73
Bug 1561705: Part 5b - Merge SpecialPowersAPIParent.jsm and SpecialPowersParent.jsm. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/f222dd497eb63df32feb4bba85ed54f966cee296
Bug 1561705: Follow-up: Disable leaky tests on linux debug. r=mccr8

Comment 14

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f3cf8ff457843354622ea4990c3769bb6ab523b
Bug 1561705: Follow-up: Fix botched skip-if annotations. r=bustage

Comment 15

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/caa41739276f17635c3fb4b034e9e98490a15676
Bug 1561705: Follow-up: Skip leaky tests on all platforms/debug. r=bustage

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/83744c33307e
https://hg.mozilla.org/mozilla-central/rev/8601c2fb82e4
https://hg.mozilla.org/mozilla-central/rev/21aaa7a6c0f6
https://hg.mozilla.org/mozilla-central/rev/8903ce08f03f
https://hg.mozilla.org/mozilla-central/rev/1cebcb44618a
https://hg.mozilla.org/mozilla-central/rev/caa59e50a7b4
https://hg.mozilla.org/mozilla-central/rev/72315ad35cbf
https://hg.mozilla.org/mozilla-central/rev/f222dd497eb6
https://hg.mozilla.org/mozilla-central/rev/8f3cf8ff4578
https://hg.mozilla.org/mozilla-central/rev/caa41739276f